Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: ui/events/blink/blink_event_util.cc

Issue 2746513002: [Compositor event queue] Queue GestureFlingStart/Cancel together with scroll/pinch (Closed)
Patch Set: Address tdresser@ and dtapuska@'s comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/blink/blink_event_util.h ('k') | ui/events/blink/input_handler_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/blink/blink_event_util.cc
diff --git a/ui/events/blink/blink_event_util.cc b/ui/events/blink/blink_event_util.cc
index f382fc1ce5bbc1f5519eed6dcbe3a358a0180828..f62fd17c11e1b46ef6af282400133b31a85feaf0 100644
--- a/ui/events/blink/blink_event_util.cc
+++ b/ui/events/blink/blink_event_util.cc
@@ -962,11 +962,13 @@ blink::WebInputEvent::Modifiers DomCodeToWebInputEventModifiers(DomCode code) {
return static_cast<blink::WebInputEvent::Modifiers>(0);
}
-bool IsGestureScollOrPinch(WebInputEvent::Type type) {
+bool IsGestureScrollFlingOrPinch(WebInputEvent::Type type) {
dtapuska 2017/03/14 15:06:51 Isn't it IsGestureScrollOrFlingOrPinch?
tdresser 2017/03/14 15:27:15 I was reading it with an implicit "," between Scro
chongz 2017/03/14 17:51:24 I've renamed it to |IsGestureScrollOrFlingOrPinch(
switch (type) {
case blink::WebGestureEvent::GestureScrollBegin:
case blink::WebGestureEvent::GestureScrollUpdate:
case blink::WebGestureEvent::GestureScrollEnd:
+ case blink::WebGestureEvent::GestureFlingStart:
+ case blink::WebGestureEvent::GestureFlingCancel:
case blink::WebGestureEvent::GesturePinchBegin:
case blink::WebGestureEvent::GesturePinchUpdate:
case blink::WebGestureEvent::GesturePinchEnd:
« no previous file with comments | « ui/events/blink/blink_event_util.h ('k') | ui/events/blink/input_handler_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698