ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResource.java - Issue 2746483003: ui/android: Fix Resource meta-data sharing with ResourceManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResource.java

Issue 2746483003: ui/android: Fix Resource meta-data sharing with ResourceManager. (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/android/java/src/org/chromium/ui/resources/ResourceManager.java ('K') | « ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceAdapter.java ('k') | ui/android/java/src/org/chromium/ui/resources/statics/StaticResource.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResource.java

diff --git a/ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResource.java b/ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResource.java

index 3c435b90feaea91acdf24add8cb479b50385868e..33a8911e46b0cf73e2f4f3a160784721dcc707cd 100644

--- a/ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResource.java

+++ b/ui/android/java/src/org/chromium/ui/resources/sprites/CrushedSpriteResource.java

@@ -82,13 +82,8 @@ public class CrushedSpriteResource implements Resource {

}

@Override

- public Rect getPadding() {

- return EMPTY_RECT;

- }

- @Override

- public Rect getAperture() {

- return EMPTY_RECT;

+ public long createNativeResource() {

+ return 0;

David Trainor- moved to gerrit 2017/03/14 18:31:52 Add a TODO to figure this out.

Khushal 2017/03/15 01:50:06 Done.

}

/**