Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 2746453005: [css-align] Adapt self-alignment properties to the new baseline syntax (Closed)
Patch Set: More layout tests fixes. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
index 46e06da84bc3c03f5131df863e6d7b4ed7c55141..7fa81114dea7e15c52ce285e966fd4cabc73ea40 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
@@ -509,6 +509,12 @@ StyleSelfAlignmentData StyleBuilderConverter::convertSelfOrDefaultAlignmentData(
alignmentData.setPositionType(LegacyPosition);
alignmentData.setPosition(
toCSSIdentifierValue(pair.second()).convertTo<ItemPosition>());
+ } else if (toCSSIdentifierValue(pair.first()).getValueID() ==
+ CSSValueFirst) {
+ alignmentData.setPosition(ItemPositionBaseline);
+ } else if (toCSSIdentifierValue(pair.first()).getValueID() ==
+ CSSValueLast) {
+ alignmentData.setPosition(ItemPositionLastBaseline);
} else {
alignmentData.setPosition(
toCSSIdentifierValue(pair.first()).convertTo<ItemPosition>());
« no previous file with comments | « third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698