Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: components/quirks/quirks_client.h

Issue 2746443002: Include display names in Quirks URL (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/quirks/quirks_client.h
diff --git a/components/quirks/quirks_client.h b/components/quirks/quirks_client.h
index 86c7adab1bd6007497931fefcdbe79b0b3024e1d..753d9073cd632058f17cd561b32b11077981294c 100644
--- a/components/quirks/quirks_client.h
+++ b/components/quirks/quirks_client.h
@@ -26,6 +26,7 @@ using RequestFinishedCallback =
class QuirksClient : public net::URLFetcherDelegate {
public:
QuirksClient(int64_t product_id,
+ std::string display_name,
oshima 2017/03/14 12:38:54 nit: const &
Greg Levin 2017/03/14 21:36:57 Done.
const RequestFinishedCallback& on_request_finished,
QuirksManager* manager);
~QuirksClient() override;
@@ -50,6 +51,9 @@ class QuirksClient : public net::URLFetcherDelegate {
// ID of display to request from Quirks Server.
const int64_t product_id_;
+ // Human-readable name to send to Quirks Server.
+ const std::string display_name_;
+
// Callback supplied by caller.
const RequestFinishedCallback on_request_finished_;

Powered by Google App Engine
This is Rietveld 408576698