Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 274643002: add mojo into Dr.Memory test build target (Closed)

Created:
6 years, 7 months ago by zhaoqin
Modified:
6 years, 7 months ago
Reviewers:
yzshen1, Derek Bruening
CC:
chromium-reviews
Visibility:
Public.

Description

add mojo into Dr.Memory test build target R=bruening@chromium.org, yzshen@chromium.org BUG=NONE NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268897

Patch Set 1 #

Total comments: 2

Patch Set 2 : reorder the build targets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
zhaoqin
6 years, 7 months ago (2014-05-07 16:15:35 UTC) #1
yzshen1
https://codereview.chromium.org/274643002/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/274643002/diff/1/build/all.gyp#newcode1081 build/all.gyp:1081: '../mojo/mojo.gyp:mojo', - It seems this list is ordered alphabetically. ...
6 years, 7 months ago (2014-05-07 16:34:59 UTC) #2
zhaoqin
https://codereview.chromium.org/274643002/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/274643002/diff/1/build/all.gyp#newcode1081 build/all.gyp:1081: '../mojo/mojo.gyp:mojo', On 2014/05/07 16:34:59, yzshen1 wrote: > - It ...
6 years, 7 months ago (2014-05-07 16:53:14 UTC) #3
yzshen1
lgtm
6 years, 7 months ago (2014-05-07 16:54:34 UTC) #4
zhaoqin
The CQ bit was checked by zhaoqin@google.com
6 years, 7 months ago (2014-05-07 17:00:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoqin@google.com/274643002/20001
6 years, 7 months ago (2014-05-07 17:03:22 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 19:33:11 UTC) #7
Message was sent while issue was closed.
Change committed as 268897

Powered by Google App Engine
This is Rietveld 408576698