Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/protobuf/proto_library.gni

Issue 2746363004: disable C4125 on windows (Closed)
Patch Set: explanatory comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/proto_library.gni
diff --git a/third_party/protobuf/proto_library.gni b/third_party/protobuf/proto_library.gni
index 84373f39d08278ba0bf11a483ed8810806377ed7..880a5af48dc927bc260e939fe96a2e4dd8f3479c 100644
--- a/third_party/protobuf/proto_library.gni
+++ b/third_party/protobuf/proto_library.gni
@@ -285,7 +285,7 @@ template("proto_library") {
if (defined(invoker.import_dirs)) {
foreach(path, invoker.import_dirs) {
- args += ["--import-dir=" + rebase_path(path, root_build_dir)]
+ args += [ "--import-dir=" + rebase_path(path, root_build_dir) ]
}
}
@@ -373,6 +373,16 @@ template("proto_library") {
"//third_party/protobuf:protobuf_lite",
]
}
+
+ if (is_win) {
+ cflags = [
+ # disable: C4125 decimal digit terminates octal escape sequence
+ # Protoc generates such sequences frequently, there's no obvious
+ # superior replacement behavior. Since this code is autogenerated,
+ # the warning would never catch a legitimate bug.
+ "/wd4125",
+ ]
+ }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698