third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp - Issue 2746343002: Phase III Step 1: Make ImageResourceContent manage its own ResourceStatus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp

Issue 2746343002: Phase III Step 1: Make ImageResourceContent manage its own ResourceStatus (Closed)

Patch Set: Rewind Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp ('K') | « third_party/WebKit/Source/core/loader/resource/ImageResourceInfo.h ('k') | third_party/WebKit/Source/platform/loader/fetch/Resource.h » ('j') | third_party/WebKit/Source/platform/loader/fetch/Resource.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp

diff --git a/third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp b/third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp

index 04326872ce90c02034c5b376c7520513f9726a84..b3148e90f18498aabeb92ca12c2fb1e06134c8f1 100644

--- a/third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp

+++ b/third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp

@@ -41,6 +41,7 @@ void MockImageResourceObserver::imageChanged(ImageResourceContent* image,

void MockImageResourceObserver::imageNotifyFinished(

ImageResourceContent* image) {

ASSERT_EQ(0, m_imageNotifyFinishedCount);

+ DCHECK(image->isLoaded());

hiroshige 2017/03/15 00:22:58 This CL enables this DCHECK(). (Previously this fa

m_imageNotifyFinishedCount++;

m_imageWidthOnImageNotifyFinished =

m_content->hasImage() ? m_content->getImage()->width() : 0;