third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp - Issue 2746343002: Phase III Step 1: Make ImageResourceContent manage its own ResourceStatus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp

Issue 2746343002: Phase III Step 1: Make ImageResourceContent manage its own ResourceStatus (Closed)

Patch Set: Reflect comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp ('k') | third_party/WebKit/Source/platform/loader/fetch/Resource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp

diff --git a/third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp b/third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp

index cbea3ddcf21e4edc46d5fa4e9fa4036eef4b0e02..4f9ff9018e4c35e182a0111e5b7c18521e2bb57e 100644

--- a/third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp

+++ b/third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.cpp

@@ -41,10 +41,11 @@ void MockImageResourceObserver::ImageChanged(ImageResourceContent* image,

void MockImageResourceObserver::ImageNotifyFinished(

ImageResourceContent* image) {

ASSERT_EQ(0, image_notify_finished_count_);

+ DCHECK(image->IsLoaded());

image_notify_finished_count_++;

image_width_on_image_notify_finished_ =

content_->HasImage() ? content_->GetImage()->width() : 0;

- status_on_image_notify_finished_ = content_->GetStatus();

+ status_on_image_notify_finished_ = content_->GetContentStatus();

}

bool MockImageResourceObserver::ImageNotifyFinishedCalled() const {