Run dartfmt on dart2js codebase.

Run dartfmt on dart2js codebase.

BUG=
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/33717e010ad2542fd548e67f56d9ab50e521439f

[Jacob, 2017-03-16 03:14:39]

jacobr@google.com changed reviewers:
+ sra@google.com

[Jacob, 2017-03-16 03:14:40]

https://codereview.chromium.org/2746333008/diff/1/pkg/compiler/lib/src/diagno...
File pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart (left):

https://codereview.chromium.org/2746333008/diff/1/pkg/compiler/lib/src/diagno...
pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart:14: const
Map<MessageKind, MessageTemplate> TEMPLATES = const <MessageKind,
MessageTemplate>{
This file is generated. Does it make sense to keep it formatted so it is more
readable?

[sra1, 2017-03-16 03:25:30]

LGTM except for the generated file.

https://codereview.chromium.org/2746333008/diff/1/pkg/compiler/lib/src/diagno...
File pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart (left):

https://codereview.chromium.org/2746333008/diff/1/pkg/compiler/lib/src/diagno...
pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart:14: const
Map<MessageKind, MessageTemplate> TEMPLATES = const <MessageKind,
MessageTemplate>{
On 2017/03/16 03:14:39, Jacob wrote:
> This file is generated. Does it make sense to keep it formatted so it is more
> readable?

It says DON'T EDIT.
The way to make this file compatible with dartfmt is to fix the generator to
call dartfmt.
I'm not sure where the generator is.

[Jacob, 2017-03-16 03:37:57]

Discussed offline.
Summary:
When the next person actually wants to regenerate the file
at that point they should tweak the generation script if
there is one so that dartfmt is called as the final step
as is the best practice dealing with generated code now
that dartfmt exists.

[Jacob, 2017-03-16 03:37:57]

Discussed offline.
Summary:
When the next person actually wants to regenerate the file
at that point they should tweak the generation script if
there is one so that dartfmt is called as the final step
as is the best practice dealing with generated code now
that dartfmt exists.

[Jacob, 2017-03-16 03:38:22]

Description was changed from

==========
Run dartfmt on dart2js codebase.

BUG=
==========

to

==========
Run dartfmt on dart2js codebase.

BUG=
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/33717e010ad2542fd548e67f56d9ab50e521439f
==========

[Jacob, 2017-03-16 03:38:23]

Committed patchset #1 (id:1) manually as
33717e010ad2542fd548e67f56d9ab50e521439f (presubmit successful).