Issue 2746333005: Parse for-look statements with Fasta.

Issue 2746333005: Parse for-look statements with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov

Modified:
3 years, 9 months ago

Reviewers:
ahe, Paul Berry

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -89 lines)			Patch
M	pkg/analyzer/test/generated/parser_fasta_test.dart	View	1	1 chunk	+0 lines, -54 lines	0 comments	Download
M	pkg/compiler/lib/src/parser/node_listener.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart	View	1	4 chunks	+37 lines, -19 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/kernel/body_builder.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/parser/listener.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/parser/parser.dart	View	1	4 chunks	+9 lines, -8 lines	0 comments	Download
M	pkg/front_end/test/fasta/kompile.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

Paul Berry

Nit: In the CL description, I think you mean "for-loop", not "for-look". Otherwise lgtm.

3 years, 9 months ago (2017-03-14 22:05:37 UTC) #2

scheglov

3 years, 9 months ago (2017-03-15 18:40:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ae85bcf954b0e009a6bb375ca7b92177331dcc94 (presubmit successful).