Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

Issue 2746333002: DevTools: move recurring flag into AsyncTask, control cancelation from embedder only. (Closed)
Patch Set: using _END now Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp b/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
index d873b576e8e38bfb5d094ca3b98ae5211093161a..20be75d5b425ad555255007a2ddf9976b46f0a2f 100644
--- a/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
@@ -103,6 +103,9 @@ ScriptedIdleTaskController::registerCallback(
m_callbacks.set(id, callback);
long long timeoutMillis = options.timeout();
+ probe::asyncTaskScheduled(getExecutionContext(), "requestIdleCallback",
+ callback);
+
RefPtr<internal::IdleRequestCallbackWrapper> callbackWrapper =
internal::IdleRequestCallbackWrapper::create(id, this);
m_scheduler->postIdleTask(
@@ -158,7 +161,7 @@ void ScriptedIdleTaskController::runCallback(
double deadlineSeconds,
IdleDeadline::CallbackType callbackType) {
DCHECK(!m_suspended);
- auto callback = m_callbacks.take(id);
+ IdleRequestCallback* callback = m_callbacks.take(id);
if (!callback)
return;
@@ -170,8 +173,10 @@ void ScriptedIdleTaskController::runCallback(
("WebCore.ScriptedIdleTaskController.IdleCallbackDeadline", 0, 50, 50));
idleCallbackDeadlineHistogram.count(allottedTimeMillis);
+ probe::AsyncTask asyncTask(getExecutionContext(), callback);
probe::UserCallback probe(getExecutionContext(), "requestIdleCallback",
AtomicString(), true);
+
TRACE_EVENT1(
"devtools.timeline", "FireIdleCallback", "data",
InspectorIdleCallbackFireEvent::data(
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/fileapi/FileReader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698