DevTools: move recurring flag into AsyncTask, control cancelation from embedder only.

third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 319 matching lines @@
         e._blackboxRoot = true;
       }
       if (title) {
         this._appendHeader(title, style, forceExpanded);
         title = '';
       }
 
       var level = this._currentLevel + openEvents.length;
       if (flowEventsEnabled)
         this._appendFlowEvent(e, level);
-      this._appendEvent(e, level);
+      if (e.phase !== SDK.TracingModel.Phase.FlowEnd)
+        this._appendEvent(e, level);
       if (!isExtension && TimelineModel.TimelineModel.isMarkerEvent(e))
         this._timelineData.entryTotalTimes[this._entryData.length] = undefined;
 
       maxStackDepth = Math.max(maxStackDepth, openEvents.length + 1);
       if (e.endTime)
         openEvents.push(e);
     }
     this._entryTypeByLevel.length = this._currentLevel + maxStackDepth;
     this._entryTypeByLevel.fill(entryType, this._currentLevel);
     this._currentLevel += maxStackDepth;
@@ skipping 397 matching lines @@
       timelineData.flowStartTimes.push(event.startTime);
       timelineData.flowStartLevels.push(level);
       return flowIndex;
     }
 
     /**
      * @param {!SDK.TracingModel.Event} event
      * @param {number} flowIndex
      */
     function pushEndFlow(event, flowIndex) {
+      if (flowIndex < 0)

[caseq, 2017/03/14 02:09:43]

How can this happen?

[pfeldman, 2017/03/14 02:29:24]

That's a way to filter out things. Filtering in the index-based array is tricky.

+        return;
       timelineData.flowEndTimes[flowIndex] = event.startTime;
       timelineData.flowEndLevels[flowIndex] = level;
     }
 
     switch (event.phase) {
       case SDK.TracingModel.Phase.FlowBegin:
         this._flowEventIndexById.set(event.id, pushStartFlow(event));
         break;
       case SDK.TracingModel.Phase.FlowStep:
         pushEndFlow(event, this._flowEventIndexById.get(event.id));

[caseq, 2017/03/14 02:44:47]

btw, I think you shouldn't use  raw event id for things like this -- this would
only make sense along with process id the way you use it on the back-end side. A
good way to avoid problems with id clashes would be perhaps to handle linking
flow events on the tracing model side.

         this._flowEventIndexById.set(event.id, pushStartFlow(event));
         break;
       case SDK.TracingModel.Phase.FlowEnd:
         pushEndFlow(event, this._flowEventIndexById.get(event.id));
         this._flowEventIndexById.delete(event.id);
         break;
     }
   }
 
   /**
@@ skipping 90 matching lines @@
    * @return {boolean}
    */
   _isVisible(event) {
     return this._filters.every(function(filter) {
       return filter.accept(event);
     });
   }
 };
 
 Timeline.TimelineFlameChartDataProvider.InstantEventVisibleDurationMs = 0.001;