DevTools: move recurring flag into AsyncTask, control cancelation from embedder only.

third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 319 matching lines @@
         e._blackboxRoot = true;
       }
       if (title) {
         this._appendHeader(title, style, forceExpanded);
         title = '';
       }
 
       var level = this._currentLevel + openEvents.length;
       if (flowEventsEnabled)
         this._appendFlowEvent(e, level);
-      this._appendEvent(e, level);
+      if (e.phase !== SDK.TracingModel.Phase.FlowEnd)
+        this._appendEvent(e, level);
       if (!isExtension && TimelineModel.TimelineModel.isMarkerEvent(e))
         this._timelineData.entryTotalTimes[this._entryData.length] = undefined;
 
       maxStackDepth = Math.max(maxStackDepth, openEvents.length + 1);
       if (e.endTime)
         openEvents.push(e);
     }
     this._entryTypeByLevel.length = this._currentLevel + maxStackDepth;
     this._entryTypeByLevel.fill(entryType, this._currentLevel);
     this._currentLevel += maxStackDepth;
@@ skipping 386 matching lines @@
    * @param {!SDK.TracingModel.Event} event
    * @param {number} level
    */
   _appendFlowEvent(event, level) {
     var timelineData = this._timelineData;
     /**
      * @param {!SDK.TracingModel.Event} event
      * @return {number}
      */
     function pushStartFlow(event) {
+      if (event.args.name === 'Image')

[alph, 2017/03/14 00:39:37]

What's wrong with Image?

[pfeldman, 2017/03/14 01:15:10]

I'll drop it.

[caseq, 2017/03/14 01:15:43]

This is supposed to work for the generic case of flow events, having some logic
depending on what data the event carries, even without the regard to the name of
the event is not lgtm.

+        return -1;
       var flowIndex = timelineData.flowStartTimes.length;
       timelineData.flowStartTimes.push(event.startTime);
       timelineData.flowStartLevels.push(level);
       return flowIndex;
     }
 
     /**
      * @param {!SDK.TracingModel.Event} event
      * @param {number} flowIndex
      */
     function pushEndFlow(event, flowIndex) {
+      if (flowIndex < 0)
+        return;
       timelineData.flowEndTimes[flowIndex] = event.startTime;
       timelineData.flowEndLevels[flowIndex] = level;
     }
 
     switch (event.phase) {
       case SDK.TracingModel.Phase.FlowBegin:
         this._flowEventIndexById.set(event.id, pushStartFlow(event));
         break;
       case SDK.TracingModel.Phase.FlowStep:
         pushEndFlow(event, this._flowEventIndexById.get(event.id));
@@ skipping 100 matching lines @@
    * @return {boolean}
    */
   _isVisible(event) {
     return this._filters.every(function(filter) {
       return filter.accept(event);
     });
   }
 };
 
 Timeline.TimelineFlameChartDataProvider.InstantEventVisibleDurationMs = 0.001;