chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc - Issue 2746313002: Remove RenderFrameHost pointer from ChooserController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc

Issue 2746313002: Remove RenderFrameHost pointer from ChooserController. (Closed)

Patch Set: Fix Android build and juncai@ comment. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc

diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc b/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc

index efd22b174a5639688528f978b9911e9c2b0e9c50..f63b11ca400c96095ef19366ff419fd3fa0de7c2 100644

--- a/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc

+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc

@@ -30,8 +30,7 @@ class ChooserDialogViewTest : public views::ViewsTestBase {

// views::ViewsTestBase:

void SetUp() override {

views::ViewsTestBase::SetUp();

- std::unique_ptr<MockChooserController> mock_chooser_controller(

- new MockChooserController(nullptr));

+ auto mock_chooser_controller = base::MakeUnique<MockChooserController>();

mock_chooser_controller_ = mock_chooser_controller.get();

std::unique_ptr<ChooserDialogView> chooser_dialog_view(

new ChooserDialogView(std::move(mock_chooser_controller)));