chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm - Issue 2746313002: Remove RenderFrameHost pointer from ChooserController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

Issue 2746313002: Remove RenderFrameHost pointer from ChooserController. (Closed)

Patch Set: Fix Android build and juncai@ comment. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/usb_chooser_dialog_android.cc ('k') | chrome/browser/ui/views/device_chooser_content_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

index ec368cb365c79288264e51d2695c706a8fdf5641..c4008adefd39cc80c5a5fb49a7b48ce2fbce5b5d 100644

--- a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

@@ -60,9 +60,7 @@ class ChooserDialogCocoaControllerTest : public CocoaProfileTest {

content::WebContents::Create(content::WebContents::CreateParams(

profile(), content::SiteInstance::Create(profile())));

ASSERT_TRUE(web_contents);

- std::unique_ptr<MockChooserController> chooser_controller(

- new MockChooserController(web_contents->GetMainFrame()));

- ASSERT_TRUE(chooser_controller);

+ auto chooser_controller = base::MakeUnique<MockChooserController>();

mock_chooser_controller_ = chooser_controller.get();

chooser_dialog_.reset(

new ChooserDialogCocoa(web_contents, std::move(chooser_controller)));