Remove RenderFrameHost pointer from ChooserController.

chrome/browser/chooser_controller/chooser_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chooser_controller/chooser_controller.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/url_formatter/elide_url.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/common/constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "url/origin.h"
 
 ChooserController::ChooserController(content::RenderFrameHost* owner,
                                      int title_string_id_origin,
-                                     int title_string_id_extension)
-    : owning_frame_(owner),
-      title_string_id_origin_(title_string_id_origin),
-      title_string_id_extension_(title_string_id_extension) {}
+                                     int title_string_id_extension) {
+  if (owner) {
+    url::Origin origin = owner->GetLastCommittedOrigin();
+
+    if (origin.scheme() == extensions::kExtensionScheme) {
+      content::WebContents* web_contents =
+          content::WebContents::FromRenderFrameHost(owner);
+      content::BrowserContext* browser_context =
+          web_contents->GetBrowserContext();
+      extensions::ExtensionRegistry* extension_registry =
+          extensions::ExtensionRegistry::Get(browser_context);
+      if (extension_registry) {
+        const extensions::Extension* extension =
+            extension_registry->enabled_extensions().GetByID(origin.host());
+        if (extension) {
+          title_ = l10n_util::GetStringFUTF16(
+              title_string_id_extension, base::UTF8ToUTF16(extension->name()));
+        }
+      }
+    } else {
+      title_ = l10n_util::GetStringFUTF16(

[msw, 2017/03/13 23:48:51]

We should also assign this value to |title_| if the above block early-outs
because it can't find the extension or registry. Optionally move this code to a
file-local anon namespace function, it'll only need a RenderFrameHost* arg.

[Reilly Grant (use Gerrit), 2017/03/14 20:44:10]

Done.

+          title_string_id_origin,
+          url_formatter::FormatOriginForSecurityDisplay(
+              origin, url_formatter::SchemeDisplay::OMIT_CRYPTOGRAPHIC));
+    }
+  }
+}
 
 ChooserController::~ChooserController() {}
 
 base::string16 ChooserController::GetTitle() const {
-  if (!owning_frame_)
-    return base::string16();
-
-  url::Origin origin = owning_frame_->GetLastCommittedOrigin();
-
-  if (origin.scheme() == extensions::kExtensionScheme) {
-    content::WebContents* web_contents =
-        content::WebContents::FromRenderFrameHost(owning_frame_);
-    content::BrowserContext* browser_context =
-        web_contents->GetBrowserContext();
-    extensions::ExtensionRegistry* extension_registry =
-        extensions::ExtensionRegistry::Get(browser_context);
-    if (extension_registry) {
-      const extensions::Extension* extension =
-          extension_registry->enabled_extensions().GetByID(origin.host());
-      if (extension) {
-        return l10n_util::GetStringFUTF16(title_string_id_extension_,
-                                          base::UTF8ToUTF16(extension->name()));
-      }
-    }
-  }
-
-  return l10n_util::GetStringFUTF16(
-      title_string_id_origin_,
-      url_formatter::FormatOriginForSecurityDisplay(
-          origin, url_formatter::SchemeDisplay::OMIT_CRYPTOGRAPHIC));
+  return title_;
 }
 
 bool ChooserController::ShouldShowIconBeforeText() const {
   return false;
 }
 
 bool ChooserController::ShouldShowFootnoteView() const {
   return true;
 }
 
 bool ChooserController::AllowMultipleSelection() const {
   return false;
 }
 
 int ChooserController::GetSignalStrengthLevel(size_t index) const {
   return -1;
 }
 
 bool ChooserController::IsConnected(size_t index) const {
   return false;
 }
 
 bool ChooserController::IsPaired(size_t index) const {
   return false;
 }
 
 void ChooserController::OpenAdapterOffHelpUrl() const {
   NOTREACHED();
 }