Hey Newton and Yaron, Please take a look at this CL. Aurimas
7 years, 2 months ago
(2013-10-16 04:43:31 UTC)
#1
Hey Newton and Yaron,
Please take a look at this CL.
Aurimas
newt (away)
lots of these are changing in all four resolutions. why is that? e.g. bubble.9.png is ...
7 years, 2 months ago
(2013-10-16 06:58:23 UTC)
#2
lots of these are changing in all four resolutions. why is that? e.g.
bubble.9.png is being added to drawable-hdpi, drawable-xhdpi, and
drawable-tvdpi, but additionally, the version in drawable is changing
aurimas (slooooooooow)
On 2013/10/16 06:58:23, newt wrote: > lots of these are changing in all four resolutions. ...
7 years, 2 months ago
(2013-10-16 07:05:29 UTC)
#3
On 2013/10/16 06:58:23, newt wrote:
> lots of these are changing in all four resolutions. why is that? e.g.
> bubble.9.png is being added to drawable-hdpi, drawable-xhdpi, and
> drawable-tvdpi, but additionally, the version in drawable is changing
drawable-hdpi, drawable-xhdpi and drawable-tvdpi did not exist previously.
drawable ones are being replaced because sgabriel said this:
"I attached all the assets. I took this opportunity to revamp some of these and
build a new source file for me.
Can you swap all the assets in "content_chrome_assets.zip" ?"
newt (away)
gotcha, lgtm
7 years, 2 months ago
(2013-10-16 16:50:09 UTC)
#4
gotcha, lgtm
Yaron
rs lgtm but /me worries about apk size
7 years, 2 months ago
(2013-10-16 16:51:54 UTC)
#5
rs lgtm but /me worries about apk size
Yaron
Actually, for that matter: can TVdpi (aka tv i presume) ever show an infobar?
7 years, 2 months ago
(2013-10-16 16:52:41 UTC)
#6
Actually, for that matter: can TVdpi (aka tv i presume) ever show an infobar?
aurimas (slooooooooow)
On 2013/10/16 16:52:41, Yaron wrote: > Actually, for that matter: can TVdpi (aka tv i ...
7 years, 2 months ago
(2013-10-16 20:51:06 UTC)
#7
On 2013/10/16 16:52:41, Yaron wrote:
> Actually, for that matter: can TVdpi (aka tv i presume) ever show an infobar?
Original nexus 7 is TVDPI and yes TVs shows infobars too.
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/27463002/13001
7 years, 2 months ago
(2013-10-17 01:57:35 UTC)
#8
Issue 27463002: Adding missing assets.
(Closed)
Created 7 years, 2 months ago by aurimas (slooooooooow)
Modified 7 years, 2 months ago
Reviewers: Yaron, newt (away)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0