Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2746293004: Add an object that can manage which plugins are associated with each context / driver (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an object that can manage which plugins are associated with each context / driver R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/72323291feb97fbbb10abc54c39c3cc02a589aaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1053 lines, -0 lines) Patch
A pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 1 chunk +499 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 1 chunk +554 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 9 months ago (2017-03-14 18:08:29 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-03-14 18:34:40 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-14 19:09:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72323291feb97fbbb10abc54c39c3cc02a589aaf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698