device/vr/android/gvr/gvr_device.h - Issue 2746233002: Fixes 2D-to-WebVR site transitions when browsing in VR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/android/gvr/gvr_device.h

Issue 2746233002: Fixes 2D-to-WebVR site transitions when browsing in VR. (Closed)

Patch Set: Rebased on ToT, nits, removed DCHECK Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/android/gvr/gvr_device.h

diff --git a/device/vr/android/gvr/gvr_device.h b/device/vr/android/gvr/gvr_device.h

index 4478e1f513da53d56bf831bdab4c4c079cebea3c..cf24a378434d6eaa62f26fccb64bc1db0c641523 100644

--- a/device/vr/android/gvr/gvr_device.h

+++ b/device/vr/android/gvr/gvr_device.h

@@ -19,8 +19,8 @@ class DEVICE_VR_EXPORT GvrDevice : public VRDevice {

~GvrDevice() override;

// VRDevice

- void GetVRDevice(

- const base::Callback<void(mojom::VRDisplayInfoPtr)>& callback) override;

+ void CreateVRDisplayInfo(

+ const base::Callback<void(mojom::VRDisplayInfoPtr)>& on_created) override;

void ResetPose() override;

void RequestPresent(mojom::VRSubmitFrameClientPtr submit_client,

« no previous file with comments | « no previous file | device/vr/android/gvr/gvr_device.cc » ('j') | device/vr/vr_service_impl.cc » ('J')