Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: device/vr/android/gvr/gvr_device.cc

Issue 2746233002: Fixes 2D-to-WebVR site transitions when browsing in VR. (Closed)
Patch Set: nit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/android/gvr/gvr_device.cc
diff --git a/device/vr/android/gvr/gvr_device.cc b/device/vr/android/gvr/gvr_device.cc
index f0a86e2fd9a94fb14ecff45c05a1d120fa63521a..8a18d45fe038684838e6a73854934b74714645b9 100644
--- a/device/vr/android/gvr/gvr_device.cc
+++ b/device/vr/android/gvr/gvr_device.cc
@@ -24,13 +24,13 @@ GvrDevice::GvrDevice(GvrDeviceProvider* provider)
GvrDevice::~GvrDevice() {}
-void GvrDevice::GetVRDevice(
- const base::Callback<void(mojom::VRDisplayInfoPtr)>& callback) {
+void GvrDevice::CreateVRDisplayInfo(
+ const base::Callback<void(mojom::VRDisplayInfoPtr)>& onCreated) {
GvrDelegate* delegate = GetGvrDelegate();
if (delegate) {
- delegate->CreateVRDisplayInfo(callback, id());
+ delegate->CreateVRDisplayInfo(onCreated, id());
} else {
- callback.Run(mojom::VRDisplayInfoPtr(nullptr));
+ onCreated.Run(mojom::VRDisplayInfoPtr(nullptr));
dcheng 2017/03/16 05:38:22 Unrelated, but this is typically written: on_crea
tiborg 2017/03/16 15:02:39 Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698