Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: device/vr/test/fake_vr_device.cc

Issue 2746233002: Fixes 2D-to-WebVR site transitions when browsing in VR. (Closed)
Patch Set: Fixed export Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/vr/test/fake_vr_device.h ('k') | device/vr/vr_device.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/vr/test/fake_vr_device.cc
diff --git a/device/vr/test/fake_vr_device.cc b/device/vr/test/fake_vr_device.cc
index 9595e5ffbd270b9bebc8ecbfb8f4be9460a3087d..ee89edbfb855e567a043cd73f4801af3d25d54b5 100644
--- a/device/vr/test/fake_vr_device.cc
+++ b/device/vr/test/fake_vr_device.cc
@@ -7,7 +7,7 @@
namespace device {
FakeVRDevice::FakeVRDevice() {
- device_ = mojom::VRDisplayInfo::New();
+ display_info_ = mojom::VRDisplayInfo::New();
InitBasicDevice();
}
@@ -15,17 +15,17 @@ FakeVRDevice::FakeVRDevice() {
FakeVRDevice::~FakeVRDevice() {}
void FakeVRDevice::InitBasicDevice() {
- device_->index = id();
- device_->displayName = "FakeVRDevice";
+ display_info_->index = id();
+ display_info_->displayName = "FakeVRDevice";
- device_->capabilities = mojom::VRDisplayCapabilities::New();
- device_->capabilities->hasOrientation = true;
- device_->capabilities->hasPosition = false;
- device_->capabilities->hasExternalDisplay = false;
- device_->capabilities->canPresent = false;
+ display_info_->capabilities = mojom::VRDisplayCapabilities::New();
+ display_info_->capabilities->hasOrientation = true;
+ display_info_->capabilities->hasPosition = false;
+ display_info_->capabilities->hasExternalDisplay = false;
+ display_info_->capabilities->canPresent = false;
- device_->leftEye = InitEye(45, -0.03f, 1024);
- device_->rightEye = InitEye(45, 0.03f, 1024);
+ display_info_->leftEye = InitEye(45, -0.03f, 1024);
+ display_info_->rightEye = InitEye(45, 0.03f, 1024);
}
mojom::VREyeParametersPtr FakeVRDevice::InitEye(float fov,
@@ -50,14 +50,14 @@ mojom::VREyeParametersPtr FakeVRDevice::InitEye(float fov,
return eye;
}
-void FakeVRDevice::SetVRDevice(const mojom::VRDisplayInfoPtr& device) {
- device_ = device.Clone();
+void FakeVRDevice::SetVRDevice(const mojom::VRDisplayInfoPtr& display_info) {
+ display_info_ = display_info.Clone();
}
-void FakeVRDevice::GetVRDevice(
- const base::Callback<void(mojom::VRDisplayInfoPtr)>& callback) {
- mojom::VRDisplayInfoPtr display = device_.Clone();
- callback.Run(std::move(display));
+void FakeVRDevice::CreateVRDisplayInfo(
+ const base::Callback<void(mojom::VRDisplayInfoPtr)>& on_created) {
+ mojom::VRDisplayInfoPtr display = display_info_.Clone();
+ on_created.Run(std::move(display));
}
void FakeVRDevice::ResetPose() {}
« no previous file with comments | « device/vr/test/fake_vr_device.h ('k') | device/vr/vr_device.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698