Fixes 2D-to-WebVR site transitions when browsing in VR.

device/vr/vr_device_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_VR_VR_DEVICE_MANAGER_H
 #define DEVICE_VR_VR_DEVICE_MANAGER_H
 
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/threading/thread_checker.h"
 #include "base/timer/timer.h"
 #include "device/vr/vr_device.h"
 #include "device/vr/vr_device_provider.h"
 #include "device/vr/vr_export.h"
 #include "device/vr/vr_service.mojom.h"
 #include "device/vr/vr_service_impl.h"
 #include "mojo/public/cpp/bindings/binding_set.h"
 
 namespace device {
 
+// Singleton used to provide the system's VR devices to VRServiceImpl instances.

[mthiesse, 2017/03/13 22:17:29]

nit: s/system/platform/?

[tiborg, 2017/03/13 23:00:58]

Done.

 class VRDeviceManager {
  public:
   DEVICE_VR_EXPORT virtual ~VRDeviceManager();
 
   // Returns the VRDeviceManager singleton.
   static VRDeviceManager* GetInstance();
 
   // Adds a listener for device manager events. VRDeviceManager does not own
-  // this object.
+  // this object. Automatically connects all currently available VR devices to

[amp, 2017/03/13 22:26:05]

That's quite an additional comment here.  Can we add some clarification on how
the automation of adding available devices work?

[tiborg, 2017/03/13 23:00:58]

Elaborated a bit. Is this more understandable?

[amp, 2017/03/14 17:05:50]

Yes, it doesn't sound like magic now. :)

+  // this service.
   void AddService(VRServiceImpl* service);
   void RemoveService(VRServiceImpl* service);
 
-  DEVICE_VR_EXPORT bool GetVRDevices(VRServiceImpl* service);
   DEVICE_VR_EXPORT unsigned int GetNumberOfConnectedDevices();
 
   void ListeningForActivateChanged(bool listening);
 
  private:
   friend class VRDeviceManagerTest;
   friend class VRDisplayImplTest;
   friend class VRServiceImplTest;
 
   VRDeviceManager();
@@ skipping 34 matching lines @@
   base::ThreadChecker thread_checker_;
 
   base::RepeatingTimer timer_;
 
   DISALLOW_COPY_AND_ASSIGN(VRDeviceManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_VR_VR_DEVICE_MANAGER_H