Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 27462002: Remove web/{android, gtk, win} (Closed)

Created:
7 years, 2 months ago by r.kasibhatla
Modified:
7 years, 2 months ago
CC:
blink-reviews, Wez, tfarina
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove web/{android, gtk, win} The {android, gtk, win} directories contain only WebInputEventFactory.cpp. We can just move these files to web/ with files renamed as WebInputEventFactoryAndroid.cpp, WebInputEventFactoryGtk.cpp, WebInputEventFactoryWin.cpp respectively and remove the dir. Moved the WebInputEventFactory.mm also to web/ but since web/mac/ still contains one more file, retained the dir. Probably can move the file also to web/ and remove the dir. BUG=None TEST=None;no behavior changes; Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2445 lines) Patch
A + Source/web/WebInputEventFactory.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/web/WebInputEventFactoryAndroid.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/web/WebInputEventFactoryGtk.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/web/WebInputEventFactoryWin.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D Source/web/android/WebInputEventFactory.cpp View 1 chunk +0 lines, -179 lines 0 comments Download
D Source/web/gtk/WebInputEventFactory.cpp View 1 chunk +0 lines, -628 lines 0 comments Download
D Source/web/mac/WebInputEventFactory.mm View 1 chunk +0 lines, -1148 lines 0 comments Download
M Source/web/web.gyp View 4 chunks +21 lines, -1 line 0 comments Download
M Source/web/web.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
D Source/web/win/WebInputEventFactory.cpp View 1 chunk +0 lines, -489 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
r.kasibhatla
7 years, 2 months ago (2013-10-16 07:50:44 UTC) #1
r.kasibhatla
On 2013/10/16 07:50:44, r.kasibhatla wrote: PTAL
7 years, 2 months ago (2013-10-16 08:42:37 UTC) #2
eseidel
lgtm
7 years, 2 months ago (2013-10-16 11:55:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/27462002/1
7 years, 2 months ago (2013-10-16 11:55:39 UTC) #4
commit-bot: I haz the power
Change committed as 159777
7 years, 2 months ago (2013-10-16 14:45:55 UTC) #5
tdanderson
On 2013/10/16 14:45:55, I haz the power (commit-bot) wrote: > Change committed as 159777 Note ...
7 years, 2 months ago (2013-10-16 16:09:41 UTC) #6
tfarina
7 years, 2 months ago (2013-10-16 16:52:38 UTC) #7
Message was sent while issue was closed.
WebInputEventFactory.mm -> WebInputEventFactoryMac.mm ?

Powered by Google App Engine
This is Rietveld 408576698