third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp - Issue 2746153008: Fix bug causing TextIterator to duplicate leading spaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

Issue 2746153008: Fix bug causing TextIterator to duplicate leading spaces (Closed)

Patch Set: also remove method definition from header Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

index d124ac45be723eae551ef135514992fcf0c9aad5..f29aad84da8f70804a513163b3fac936dd8325c6 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

@@ -152,8 +152,7 @@ TEST_F(FrameSelectionTest, SelectWordAroundPosition2) {

Node* const baz = document().body()->firstChild()->lastChild();

EXPECT_TRUE(selection().selectWordAroundPosition(

createVisiblePosition(Position(baz, 2))));

- // TODO(yoichio): We should select only "baz".

- EXPECT_EQ_SELECTED_TEXT(" baz");

+ EXPECT_EQ_SELECTED_TEXT("baz");

}

TEST_F(FrameSelectionTest, ModifyExtendWithFlatTree) {