Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2319)

Unified Diff: chrome/browser/ui/certificate_viewer_mac.mm

Issue 2746103003: Add X509CertificateBytes which uses CRYPTO_BUFFER instead of macOS-native certificate types. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/certificate_viewer_mac.mm
diff --git a/chrome/browser/ui/certificate_viewer_mac.mm b/chrome/browser/ui/certificate_viewer_mac.mm
index 6415e99f9486ec9d986d58e0d47de12fc838e489..370ee6d234fb201f976d78c44891e0dca3ff8301 100644
--- a/chrome/browser/ui/certificate_viewer_mac.mm
+++ b/chrome/browser/ui/certificate_viewer_mac.mm
@@ -99,7 +99,10 @@ void MaybeConstrainPanelSizeForSierraBug() {
forWebContents:(content::WebContents*)webContents {
if ((self = [super init])) {
base::ScopedCFTypeRef<CFArrayRef> certChain(
- certificate->CreateOSCertChainForCert());
+ net::x509_util::CreateSecCertificateArrayForX509Certificate(
+ certificate));
+ if (!certChain)
+ return self;
NSArray* certificates = base::mac::CFToNSCast(certChain.get());
certificates_.reset([certificates retain]);
}
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698