Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: net/cert/x509_certificate_unittest.cc

Issue 2746103003: Add X509CertificateBytes which uses CRYPTO_BUFFER instead of macOS-native certificate types. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/x509_certificate_unittest.cc
diff --git a/net/cert/x509_certificate_unittest.cc b/net/cert/x509_certificate_unittest.cc
index da2545134cfbe88f2949c8fde5d0497949d11c5b..af5e01f2d02f28bb12ac2a16bb6ce095e6f21a55 100644
--- a/net/cert/x509_certificate_unittest.cc
+++ b/net/cert/x509_certificate_unittest.cc
@@ -1201,16 +1201,13 @@ const struct PublicKeyInfoTestData {
size_t expected_bits;
X509Certificate::PublicKeyType expected_type;
} kPublicKeyInfoTestData[] = {
- {"768-rsa-ee-by-768-rsa-intermediate.pem",
- 768,
+ {"768-rsa-ee-by-768-rsa-intermediate.pem", 768,
X509Certificate::kPublicKeyTypeRSA},
- {"1024-rsa-ee-by-768-rsa-intermediate.pem",
- 1024,
+ {"1024-rsa-ee-by-768-rsa-intermediate.pem", 1024,
X509Certificate::kPublicKeyTypeRSA},
- {"prime256v1-ecdsa-ee-by-1024-rsa-intermediate.pem",
- 256,
+ {"prime256v1-ecdsa-ee-by-1024-rsa-intermediate.pem", 256,
X509Certificate::kPublicKeyTypeECDSA},
-#if defined(OS_MACOSX) && !defined(OS_IOS)
+#if defined(OS_MACOSX) && !defined(OS_IOS) && !defined(USE_BYTE_CERTS)
// OS X has an key length limit of 4096 bits. This should manifest as an
// unknown key. If a future version of OS X changes this, large_key.pem may
// need to be renegerated with a larger key. See https://crbug.com/472291.

Powered by Google App Engine
This is Rietveld 408576698