JDA unittest: add an abort test case.

media/gpu/jpeg_decode_accelerator_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This has to be included first.
 // See http://code.google.com/p/googletest/issues/detail?id=371
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include <stddef.h>
 #include <stdint.h>
@@ skipping 421 matching lines @@
   // The elements of |test_image_files_| are owned by
   // JpegDecodeAcceleratorTestEnvironment.
   std::vector<TestImageFile*> test_image_files_;
   std::vector<ClientState> expected_status_;
 
  protected:
   DISALLOW_COPY_AND_ASSIGN(JpegDecodeAcceleratorTest);
 };
 
 void JpegDecodeAcceleratorTest::TestDecode(size_t num_concurrent_decoders) {
-  LOG_ASSERT(test_image_files_.size() == expected_status_.size());
+  LOG_ASSERT(test_image_files_.size() >= expected_status_.size());
   base::Thread decoder_thread("DecoderThread");
   ASSERT_TRUE(decoder_thread.Start());
 
   ScopedVector<ClientStateNotification<ClientState>> notes;
   ScopedVector<JpegClient> clients;
 
   for (size_t i = 0; i < num_concurrent_decoders; i++) {
     notes.push_back(new ClientStateNotification<ClientState>());
     clients.push_back(new JpegClient(test_image_files_, notes.back()));
     decoder_thread.task_runner()->PostTask(
         FROM_HERE, base::Bind(&JpegClient::CreateJpegDecoder,
                               base::Unretained(clients.back())));
     ASSERT_EQ(notes[i]->Wait(), CS_INITIALIZED);
   }
 
   for (size_t index = 0; index < test_image_files_.size(); index++) {
     for (size_t i = 0; i < num_concurrent_decoders; i++) {
       decoder_thread.task_runner()->PostTask(
           FROM_HERE, base::Bind(&JpegClient::StartDecode,
                                 base::Unretained(clients[i]), index));
     }
-    for (size_t i = 0; i < num_concurrent_decoders; i++) {
-      ASSERT_EQ(notes[i]->Wait(), expected_status_[index]);
+    if (index < expected_status_.size()) {
+      for (size_t i = 0; i < num_concurrent_decoders; i++) {
+        ASSERT_EQ(notes[i]->Wait(), expected_status_[index]);
+      }
     }
   }
 
   for (size_t i = 0; i < num_concurrent_decoders; i++) {
     decoder_thread.task_runner()->PostTask(
         FROM_HERE, base::Bind(&JpegClient::DestroyJpegDecoder,
                               base::Unretained(clients[i])));
   }
   decoder_thread.Stop();
 }
@@ skipping 47 matching lines @@
 }
 
 TEST_F(JpegDecodeAcceleratorTest, KeepDecodeAfterFailure) {
   test_image_files_.push_back(g_env->image_data_invalid_.get());
   test_image_files_.push_back(g_env->image_data_1280x720_default_.get());
   expected_status_.push_back(CS_ERROR);
   expected_status_.push_back(CS_DECODE_PASS);
   TestDecode(1);
 }
 
+TEST_F(JpegDecodeAcceleratorTest, Abort) {
+  const int kNumOfJpegToDecode = 5;

[jcliang, 2017/03/13 08:52:34]

const size_t

[wuchengli, 2017/03/13 14:20:08]

Will fix in next PS.

+  for (int j = 0; j < kNumOfJpegToDecode; j++)

[jcliang, 2017/03/13 08:52:34]

size_t j

[wuchengli, 2017/03/13 14:20:08]

Will fix in next PS.

+    test_image_files_.push_back(g_env->image_data_1280x720_default_.get());
+  // Verify only one decode success and ensure both decoders have started the
+  // decoding. Then destroy the first decoder when it is still decoding. The

[jcliang, 2017/03/13 08:52:34]

Are we relying on TestDecode() to destroy the first decoder? Is it guaranteed
that the first decoder is destroyed before the decoding is done?

[wuchengli, 2017/03/13 14:20:08]

Yes. We are relying on TestDecode() to destroy the first decoder. It's not
guaranteed but the odds is very high.
- After JDA decodes the first frame, we send four more to decode without
waiting. Then destroy the decoder.
- Each decode takes several milliseconds.
We can increase kNumOfJpegToDecode if we want to increase the odds.

+  // kernel should not crash during this test.
+  expected_status_.push_back(CS_DECODE_PASS);
+  TestDecode(2);
+}
+
 }  // namespace
 }  // namespace media
 
 int main(int argc, char** argv) {
   testing::InitGoogleTest(&argc, argv);
   base::CommandLine::Init(argc, argv);
   base::ShadowingAtExitManager at_exit_manager;
 
   // Needed to enable DVLOG through --vmodule.
   logging::LoggingSettings settings;
@@ skipping 26 matching lines @@
 #if defined(OS_CHROMEOS) && defined(ARCH_CPU_X86_FAMILY)
   media::VaapiWrapper::PreSandboxInitialization();
 #endif
 
   media::g_env = reinterpret_cast<media::JpegDecodeAcceleratorTestEnvironment*>(
       testing::AddGlobalTestEnvironment(
           new media::JpegDecodeAcceleratorTestEnvironment(jpeg_filenames)));
 
   return RUN_ALL_TESTS();
 }