Add password form search using blink::WebNode reference comparison.

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 2157 matching lines @@
 
   SimulateUsernameChange("Bob");
   SimulatePasswordChange("mypassword");
 
   password_autofill_agent_->AJAXSucceeded();
 
   base::RunLoop().RunUntilIdle();
   ASSERT_FALSE(fake_driver_.called_password_form_submitted());
 }
 
+// Tests that no save promt is shown when an unowned form is changed and AJAX
+// completed but the form is still visible.
+TEST_F(PasswordAutofillAgentTest,
+       NoForm_NoPromptForAJAXSubmitWithoutNavigationAndNewElementAppeared) {
+  const char kNoFormHTMLWithHiddenField[] =
+      "<INPUT type='text' id='username'/>"
+      "<INPUT type='password' id='password'/>"
+      "<INPUT type='text' id='captcha' style='display:none'/>";
+  LoadHTML(kNoFormHTMLWithHiddenField);
+
+  UpdateUsernameAndPasswordElements();
+  WebElement captcha_element =
+      GetMainFrame()->document().getElementById(WebString::fromUTF8("captcha"));
+  ASSERT_FALSE(captcha_element.isNull());
+
+  SimulateUsernameChange("Bob");
+  SimulatePasswordChange("mypassword");
+
+  // Simulate captcha element show up right before AJAX completed.
+  captcha_element.setAttribute("style", "display:inline;");
+  password_autofill_agent_->AJAXSucceeded();
+
+  base::RunLoop().RunUntilIdle();
+  EXPECT_FALSE(fake_driver_.called_inpage_navigation());
+  EXPECT_FALSE(fake_driver_.called_password_form_submitted());
+}
+
+// Tests that no save promt is shown when a form with empty action URL is
+// changed and AJAX completed but the form is still visible.
+TEST_F(PasswordAutofillAgentTest,
+       NoAction_NoPromptForAJAXSubmitWithoutNavigationAndNewElementAppeared) {
+  // Form without an action URL.
+  const char kHTMLWithHiddenField[] =
+      "<FORM name='LoginTestForm'>"
+      "  <INPUT type='text' id='username'/>"
+      "  <INPUT type='password' id='password'/>"
+      "  <INPUT type='text' id='captcha' style='display:none'/>"
+      "  <INPUT type='submit' value='Login'/>"
+      "</FORM>";
+  // Set the valid URL so the form action URL can be generated properly.
+  LoadHTMLWithUrlOverride(kHTMLWithHiddenField, "https://www.example.com");

[dvadym, 2017/03/14 17:11:10]

Why not LoadHTML?

[sense (YandexTeam), 2017/03/15 04:51:24]

In this test we explicitly test a form without action URL. If we use LoadHTML
then form_util::GetCanonicalActionForForm() will return invalid URL and
CreatePasswordFormFromWebForm() will fail here:
password_form->action = form_util::GetCanonicalActionForForm(web_form);
if (!password_form->action.is_valid())
  return std::unique_ptr<PasswordForm>();

[dvadym, 2017/03/15 14:27:11]

Acknowledged

+
+  UpdateUsernameAndPasswordElements();
+  WebElement captcha_element =
+      GetMainFrame()->document().getElementById(WebString::fromUTF8("captcha"));
+  ASSERT_FALSE(captcha_element.isNull());
+
+  SimulateUsernameChange("Bob");
+  SimulatePasswordChange("mypassword");
+
+  // Simulate captcha element show up right before AJAX completed.
+  captcha_element.setAttribute("style", "display:inline;");
+  password_autofill_agent_->AJAXSucceeded();
+
+  base::RunLoop().RunUntilIdle();
+  EXPECT_FALSE(fake_driver_.called_inpage_navigation());
+  EXPECT_FALSE(fake_driver_.called_password_form_submitted());
+}
+
 // Tests that credential suggestions are autofilled on a password (and change
 // password) forms having either ambiguous or empty name.
 TEST_F(PasswordAutofillAgentTest,
        SuggestionsOnFormContainingAmbiguousOrEmptyNames) {
   const char kEmpty[] = "";
   const char kDummyUsernameField[] = "anonymous_username";
   const char kDummyPasswordField[] = "anonymous_password";
   const char kFormContainsEmptyNamesHTML[] =
       "<FORM name='WithoutNameIdForm' action='http://www.bidule.com' >"
       "  <INPUT type='text' placeholder='username'/>"
@@ skipping 343 matching lines @@
   SimulateElementClick(kUsernameName);
 
   // Simulate a user clicking on the password element. This should produce a
   // dropdown with suggestion of all available usernames.
   static_cast<PageClickListener*>(autofill_agent_)
       ->FormControlElementClicked(password_element_, false);
   CheckSuggestions("", false);
 }
 
 }  // namespace autofill