Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2746033003: Inline source maps as part of each script. (Closed)

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 9 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Inline source maps as part of each script. Unfortunately this is required as even with ideal caching, performing XHRs to load all source maps increased load times by ~5 seconds for large applications. Performance hit is now minimal. BUG= Review-Url: https://codereview.chromium.org/2747513003 . Committed: https://github.com/dart-lang/sdk/commit/1f38879094d14bcff846b2d0851bc9a00975943a

Patch Set 1 #

Patch Set 2 : Base64 encode inline sourcemaps to work around strange v8 bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
Already landed on ddc-1.22.0-dev.10.6 Resolved conflicts and landing on main.
3 years, 9 months ago (2017-03-13 17:42:47 UTC) #2
Jacob
Committed patchset #1 (id:1) manually as 1f38879094d14bcff846b2d0851bc9a00975943a (presubmit successful).
3 years, 9 months ago (2017-03-13 17:46:12 UTC) #4
vsm
3 years, 9 months ago (2017-03-13 17:50:41 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698