Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: pkg/analyzer/lib/src/fasta/ast_builder.dart

Issue 2746013003: [fasta] Add and correct even more offsets (Closed)
Patch Set: Removed formalParametersToken parameter Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/fasta/summary_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/fasta/ast_builder.dart
diff --git a/pkg/analyzer/lib/src/fasta/ast_builder.dart b/pkg/analyzer/lib/src/fasta/ast_builder.dart
index 97fb17cf3ccece41ed438797afc53eee95ff3b73..ac9846ea5469fba069bc66367bced3c00e040ea1 100644
--- a/pkg/analyzer/lib/src/fasta/ast_builder.dart
+++ b/pkg/analyzer/lib/src/fasta/ast_builder.dart
@@ -9,13 +9,16 @@ import 'package:analyzer/dart/ast/ast_factory.dart' show AstFactory;
import 'package:analyzer/dart/ast/standard_ast_factory.dart' as standard;
import 'package:analyzer/dart/ast/token.dart' as analyzer show Token;
import 'package:analyzer/dart/element/element.dart' show Element;
-import 'package:front_end/src/fasta/parser/parser.dart' show FormalParameterType;
-import 'package:front_end/src/fasta/scanner/token.dart' show BeginGroupToken, Token;
+import 'package:front_end/src/fasta/parser/parser.dart'
+ show FormalParameterType;
+import 'package:front_end/src/fasta/scanner/token.dart'
+ show BeginGroupToken, Token;
import 'package:front_end/src/fasta/errors.dart' show internalError;
import 'package:front_end/src/fasta/kernel/kernel_builder.dart'
show Builder, KernelLibraryBuilder, ProcedureBuilder;
-import 'package:front_end/src/fasta/parser/identifier_context.dart' show IdentifierContext;
+import 'package:front_end/src/fasta/parser/identifier_context.dart'
+ show IdentifierContext;
import 'package:front_end/src/fasta/quote.dart';
import 'package:front_end/src/fasta/source/scope_listener.dart'
show JumpTargetKind, NullValue, Scope, ScopeListener;
@@ -754,8 +757,8 @@ class AstBuilder extends ScopeListener {
}
}
- void endFormalParameter(
- Token covariantKeyword, Token thisKeyword, FormalParameterType kind) {
+ void endFormalParameter(Token covariantKeyword, Token thisKeyword,
+ Token nameToken, FormalParameterType kind) {
debugEvent("FormalParameter");
_ParameterDefaultValue defaultValue = pop();
@@ -1339,7 +1342,7 @@ class AstBuilder extends ScopeListener {
toAnalyzerToken(ofKeyword), uri, name, toAnalyzerToken(semicolon)));
}
- void endUnnamedFunction(Token token) {
+ void endUnnamedFunction(Token beginToken, Token token) {
// TODO(paulberry): set up scopes properly to resolve parameters and type
// variables. Note that this is tricky due to the handling of initializers
// in constructors, so the logic should be shared with BodyBuilder as much
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/summary/fasta/summary_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698