Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart

Issue 2746013003: [fasta] Add and correct even more offsets (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
index cbd17fb6a9f32b69292621060dbc6f59aaf9969b..f81f0d5daf18c58f22d3d95549ae42cf171ad3a4 100644
--- a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
+++ b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
@@ -621,8 +621,8 @@ class AstBuilder extends ScopeListener {
push(NullValue.ParameterDefaultValue);
}
- void endFormalParameter(
- Token covariantKeyword, Token thisKeyword, FormalParameterType kind) {
+ void endFormalParameter(Token covariantKeyword, Token thisKeyword,
+ Token nameToken, FormalParameterType kind) {
debugEvent("FormalParameter");
_ParameterDefaultValue defaultValue = pop();
@@ -847,7 +847,8 @@ class AstBuilder extends ScopeListener {
}
}
- void endTopLevelMethod(Token beginToken, Token getOrSet, Token endToken) {
+ void endTopLevelMethod(Token beginToken, Token getOrSet,
+ Token formalParametersToken, Token endToken) {
// TODO(paulberry): set up scopes properly to resolve parameters and type
// variables.
debugEvent("TopLevelMethod");
@@ -1164,7 +1165,7 @@ class AstBuilder extends ScopeListener {
toAnalyzerToken(ofKeyword), uri, name, toAnalyzerToken(semicolon)));
}
- void endUnnamedFunction(Token token) {
+ void endUnnamedFunction(Token beginToken, Token token) {
// TODO(paulberry): set up scopes properly to resolve parameters and type
// variables. Note that this is tricky due to the handling of initializers
// in constructors, so the logic should be shared with BodyBuilder as much
@@ -1184,8 +1185,8 @@ class AstBuilder extends ScopeListener {
}
@override
- void endFactoryMethod(
- Token beginToken, Token factoryKeyword, Token semicolon) {
+ void endFactoryMethod(Token beginToken, Token factoryKeyword,
+ Token formalParametersToken, Token semicolon) {
debugEvent("FactoryMethod");
FunctionBody body;
@@ -1270,7 +1271,8 @@ class AstBuilder extends ScopeListener {
}
@override
- void endMethod(Token getOrSet, Token beginToken, Token endToken) {
+ void endMethod(Token getOrSet, Token beginToken, Token formalParametersToken,
+ Token endToken) {
debugEvent("Method");
FunctionBody body = pop();
ConstructorName redirectedConstructor = null; // TODO(paulberry)

Powered by Google App Engine
This is Rietveld 408576698