MD Bookmarks: Update URL router to work in new data binding system

chrome/browser/resources/md_bookmarks/toolbar.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'bookmarks-toolbar',
 
   behaviors: [
     bookmarks.StoreClient,
   ],
@@ skipping 59 matching lines @@
     var menu = /** @type {!CrActionMenuElement} */ (this.$.dropdown);
     menu.close();
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onSearchChanged_: function(e) {
     var searchTerm = /** @type {string} */ (e.detail);
-    this.dispatch(bookmarks.actions.setSearchTerm(searchTerm));
+    if (searchTerm != this.searchTerm_)

[calamity, 2017/03/20 06:34:28]

What makes this necessary?

[tsergeant, 2017/03/21 00:27:07]

This is just a small optimisation to avoid firing off an action which does
nothing.

The flow is:

router fires a search action
StoreClient picks up a change to search term
onSearchTermChanged_ updates the search field
onSearchChanged_ sees that change to the search field, fires off an identical
search action.

This check avoids that second action.

+      this.dispatch(bookmarks.actions.setSearchTerm(searchTerm));
   },
 
   /** @private */
   onSearchTermChanged_: function() {
     this.searchField.setValue(this.searchTerm_ || '');
   },
 });