Bluetooth: macOS: Adding logs

device/bluetooth/bluetooth_low_energy_device_mac.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_LOW_ENERGY_DEVICE_MAC_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_LOW_ENERGY_DEVICE_MAC_H_
 
 #if defined(OS_IOS)
 #import <CoreBluetooth/CoreBluetooth.h>
 #else  // !defined(OS_IOS)
@@ skipping 108 matching lines @@
   // Returns the CoreBluetooth Peripheral.
   CBPeripheral* GetPeripheral();
 
   // Returns BluetoothRemoteGattServiceMac based on the CBService.
   BluetoothRemoteGattServiceMac* GetBluetoothRemoteGattService(
       CBService* service) const;
 
   // Callback used when the CoreBluetooth Peripheral is disconnected.
   void DidDisconnectPeripheral(NSError* error);
 
+  // Returns a description for the device, that should be used for logs.

[ortuno, 2017/03/14 00:34:33]

I should have suggested this before but I wasn't sure if you were planning on
using ToString outside of logging.

Given that all uses of the method are for logging we can add an implementation
of the << operator:

DEVICE_BLUETOOTH_EXPORT std::ostream& operator<<(std::ostream& out,
                                          const BluetoothDevice& device);

Then you can just do:

VLOG(1) << *this;

See
https://cs.chromium.org/chromium/src/content/common/bluetooth/web_bluetooth_d...

[jlebel, 2017/03/15 01:08:40]

Done.

+  std::string ToString() const;
+
   // CoreBluetooth data structure.
   base::scoped_nsobject<CBPeripheral> peripheral_;
 
   // Objective-C delegate for the CBPeripheral.
   base::scoped_nsobject<BluetoothLowEnergyPeripheralDelegate>
       peripheral_delegate_;
 
   // Whether the device is connectable.
   bool connectable_;
 
   // The peripheral's identifier, as returned by [CBPeripheral identifier].
   std::string identifier_;
 
   // A local address for the device created by hashing the peripheral
   // identifier.
   std::string hash_address_;
 
   // Increases each time -[CBPeripheral discoverServices:] is called, and
   // decreases each time DidDiscoverPrimaryServices() is called. Once the
   // value is set to 0, characteristics and properties are discovered.
   int discovery_pending_count_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothLowEnergyDeviceMac);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_LOW_ENERGY_DEVICE_MAC_H_