[LayoutNG] Implement atomic inlines for LayoutNGInline

third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NGLineBuilder_h
 #define NGLineBuilder_h
 
 #include "core/CoreExport.h"
 #include "core/layout/ng/geometry/ng_logical_offset.h"
 #include "core/layout/ng/ng_layout_opportunity_iterator.h"
@@ skipping 68 matching lines @@
 
   // Create fragments for all lines created so far.
   RefPtr<NGLayoutResult> CreateFragments();
 
   // Copy fragment data of all lines created by this NGLineBuilder to
   // LayoutBlockFlow.
   // This must run after |CreateFragments()|, and after the fragments it created
   // are placed.
   void CopyFragmentDataToLayoutBlockFlow();
 
+  // Compute inline size of an NGLayoutInlineItem.
+  // Same as NGLayoutInlineItem::InlineSize(), except that this function can
+  // compute atomic inlines by laying out them.

[ikilpatrick, 2017/03/16 18:26:16]

.nit
"by layout them out."
or
"by performing layout."

[kojii, 2017/03/16 19:16:33]

Done, thank you!

+  LayoutUnit InlineSize(const NGLayoutInlineItem&);
+
  private:
+  bool IsHorizontalWritingMode() const { return is_horizontal_writing_mode_; }
+
+  LayoutUnit InlineSize(const NGLayoutInlineItem&,
+                        unsigned start_offset,
+                        unsigned end_offset);
+  LayoutUnit InlineSizeFromLayout(const NGLayoutInlineItem&);
+  const NGLayoutResult* LayoutItem(const NGLayoutInlineItem&);
+
   struct LineItemChunk {
     unsigned index;
     unsigned start_offset;
     unsigned end_offset;
     LayoutUnit inline_size;
   };
 
   void BidiReorder(Vector<LineItemChunk, 32>*);
 
   // Represents block-direction metrics for an |NGLayoutInlineItem|.
@@ skipping 29 matching lines @@
     float max_descent_and_leading = 0;
 
     // Include |InlineItemMetrics| into the metrics for this line box.
     void UpdateMaxAscentAndDescent(const InlineItemMetrics&);
   };
 
   void PlaceItems(const Vector<LineItemChunk, 32>&);
   void AccumulateUsedFonts(const NGLayoutInlineItem&,
                            const LineItemChunk&,
                            LineBoxData*);
+  LayoutUnit PlaceAtomicInline(const NGLayoutInlineItem&,
+                               LayoutUnit estimated_baseline,
+                               LineBoxData*,
+                               NGFragmentBuilder*);
 
   // Finds the next layout opportunity for the next text fragment.
   void FindNextLayoutOpportunity();
 
   Persistent<NGInlineNode> inline_box_;
   NGConstraintSpace* constraint_space_;  // Not owned as STACK_ALLOCATED.
   NGFragmentBuilder* containing_block_builder_;
+  Vector<RefPtr<NGLayoutResult>, 32> layout_results_;
   Vector<RefPtr<NGPhysicalFragment>, 32> fragments_;
   Vector<NGLogicalOffset, 32> offsets_;
   Vector<LineBoxData, 32> line_box_data_list_;
   unsigned start_index_ = 0;
   unsigned start_offset_ = 0;
   unsigned last_index_ = 0;
   unsigned end_offset_ = 0;
   unsigned last_break_opportunity_index_ = 0;
   unsigned last_break_opportunity_offset_ = 0;
   LayoutUnit end_position_;
   LayoutUnit last_break_opportunity_position_;
   LayoutUnit content_size_;
   LayoutUnit max_inline_size_;
-  FontBaseline baseline_type_;
+  FontBaseline baseline_type_ = FontBaseline::AlphabeticBaseline;
 
   NGLogicalOffset bfc_offset_;
   NGLogicalRect current_opportunity_;
 
+  unsigned is_horizontal_writing_mode_ : 1;
 #if DCHECK_IS_ON()
   unsigned is_bidi_reordered_ : 1;
 #endif
 };
 
 }  // namespace blink
 
 #endif  // NGLineBuilder_h