Issue 274593003: Fix "Search Google for this image" after r268939

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274593003: Fix "Search Google for this image" after r268939 (Closed)

Created:
6 years, 7 months ago by mnaganov (inactive)

Modified:
6 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix "Search Google for this image" after r268939 CoreTabHelper receives a frame-specific message, so it needs to use the new RFH-specific OnMessageReceived BUG=371296 TBR=jam@chromium.org

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/ui/tab_contents/core_tab_helper.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/tab_contents/core_tab_helper.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

Apparently, there are no tests for this, so I had missed it.

6 years, 7 months ago (2014-05-08 11:04:38 UTC) #1

mnaganov (inactive)

The CQ bit was checked by mnaganov@chromium.org

6 years, 7 months ago (2014-05-08 11:05:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/274593003/1

6 years, 7 months ago (2014-05-08 11:06:04 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-09 03:18:39 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 7 months ago (2014-05-09 05:28:51 UTC) #6

commit-bot: I haz the power

6 years, 7 months ago (2014-05-09 05:28:51 UTC) #7

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

Expand Messages | Collapse Messages