third_party/WebKit/Source/devtools/front_end/ui/Popover.js - Issue 2745903003: [DevTools] Do not inherit ObjectPopoverHelper from PopoverHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

Issue 2745903003: [DevTools] Do not inherit ObjectPopoverHelper from PopoverHelper. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

index 8364ab74b8cdf64fd95225ccc32adfd7c798f829..37c5d528a57c53a1e9b0de17aa07caeaf42156e2 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

@@ -47,7 +47,7 @@ UI.PopoverHelper = class {

/**

* @param {function(!Element, !Event):(!Element|!AnchorBox|undefined)} getAnchor

- * @param {function(!Element, !UI.GlassPane):!Promise<boolean>} showPopover

+ * @param {function((!Element|!AnchorBox), !UI.GlassPane):!Promise<boolean>} showPopover

* @param {function()=} onHide

initializeCallbacks(getAnchor, showPopover, onHide) {