Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

Issue 2745903003: [DevTools] Do not inherit ObjectPopoverHelper from PopoverHelper. (Closed)
Patch Set: addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 /** 69 /**
70 * @param {!Element} element 70 * @param {!Element} element
71 * @param {!Event} event 71 * @param {!Event} event
72 * @return {!Element|!AnchorBox|undefined} 72 * @return {!Element|!AnchorBox|undefined}
73 */ 73 */
74 _getPopoverAnchor(element, event) { 74 _getPopoverAnchor(element, event) {
75 return this._cursorArea; 75 return this._cursorArea;
76 } 76 }
77 77
78 /** 78 /**
79 * @param {!Element} anchor 79 * @param {!Element|!AnchorBox} anchor
80 * @param {!UI.GlassPane} popover 80 * @param {!UI.GlassPane} popover
81 * @return {!Promise<boolean>} 81 * @return {!Promise<boolean>}
82 */ 82 */
83 _showPopover(anchor, popover) { 83 _showPopover(anchor, popover) {
84 return this._buildPopoverContents().then(maybeShowPopover.bind(this)); 84 return this._buildPopoverContents().then(maybeShowPopover.bind(this));
85 85
86 /** 86 /**
87 * @this {PerfUI.TimelineOverviewPane} 87 * @this {PerfUI.TimelineOverviewPane}
88 * @param {!DocumentFragment} fragment 88 * @param {!DocumentFragment} fragment
89 * @return {boolean} 89 * @return {boolean}
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 */ 544 */
545 onClick(event) { 545 onClick(event) {
546 return false; 546 return false;
547 } 547 }
548 548
549 resetCanvas() { 549 resetCanvas() {
550 this._canvas.width = this.element.clientWidth * window.devicePixelRatio; 550 this._canvas.width = this.element.clientWidth * window.devicePixelRatio;
551 this._canvas.height = this.element.clientHeight * window.devicePixelRatio; 551 this._canvas.height = this.element.clientHeight * window.devicePixelRatio;
552 } 552 }
553 }; 553 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698