Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2745903003: [DevTools] Do not inherit ObjectPopoverHelper from PopoverHelper. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Network.NetworkLogViewColumns = class { 7 Network.NetworkLogViewColumns = class {
8 /** 8 /**
9 * @param {!Network.NetworkLogView} networkLogView 9 * @param {!Network.NetworkLogView} networkLogView
10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator 10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 return; 531 return;
532 var anchor = element.enclosingNodeOrSelfWithClass('network-script-initiated' ); 532 var anchor = element.enclosingNodeOrSelfWithClass('network-script-initiated' );
533 if (anchor && anchor.request) { 533 if (anchor && anchor.request) {
534 var initiator = /** @type {!SDK.NetworkRequest} */ (anchor.request).initia tor(); 534 var initiator = /** @type {!SDK.NetworkRequest} */ (anchor.request).initia tor();
535 if (initiator && initiator.stack) 535 if (initiator && initiator.stack)
536 return anchor; 536 return anchor;
537 } 537 }
538 } 538 }
539 539
540 /** 540 /**
541 * @param {!Element} anchor 541 * @param {!Element|!AnchorBox} anchor
542 * @param {!UI.GlassPane} popover 542 * @param {!UI.GlassPane} popover
543 * @return {!Promise<boolean>} 543 * @return {!Promise<boolean>}
544 */ 544 */
545 _showPopover(anchor, popover) { 545 _showPopover(anchor, popover) {
546 var request = /** @type {!SDK.NetworkRequest} */ (anchor.request); 546 var request = /** @type {!SDK.NetworkRequest} */ (anchor.request);
547 var initiator = /** @type {!Protocol.Network.Initiator} */ (request.initiato r()); 547 var initiator = /** @type {!Protocol.Network.Initiator} */ (request.initiato r());
548 var content = Components.DOMPresentationUtils.buildStackTracePreviewContents ( 548 var content = Components.DOMPresentationUtils.buildStackTracePreviewContents (
549 request.target(), this._popupLinkifier, initiator.stack); 549 request.target(), this._popupLinkifier, initiator.stack);
550 popover.contentElement.appendChild(content); 550 popover.contentElement.appendChild(content);
551 return Promise.resolve(true); 551 return Promise.resolve(true);
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
807 /** 807 /**
808 * @enum {string} 808 * @enum {string}
809 */ 809 */
810 Network.NetworkLogViewColumns.WaterfallSortIds = { 810 Network.NetworkLogViewColumns.WaterfallSortIds = {
811 StartTime: 'startTime', 811 StartTime: 'startTime',
812 ResponseTime: 'responseReceivedTime', 812 ResponseTime: 'responseReceivedTime',
813 EndTime: 'endTime', 813 EndTime: 'endTime',
814 Duration: 'duration', 814 Duration: 'duration',
815 Latency: 'latency' 815 Latency: 'latency'
816 }; 816 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698