Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Issue 27459002: Move DEFINE_TYPE_CASTS from Node.h to Assertions.h (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move DEFINE_TYPE_CASTS from Node.h to Assertions.h As mentioned in FIXME, DEFINE_TYPE_CASTS needs to find proper place. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159753

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M Source/core/dom/Node.h View 1 chunk +0 lines, -25 lines 0 comments Download
M Source/wtf/Assertions.h View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gyuyoung-inactive
7 years, 2 months ago (2013-10-16 03:36:30 UTC) #1
tkent
lgtm
7 years, 2 months ago (2013-10-16 03:40:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/27459002/1
7 years, 2 months ago (2013-10-16 03:41:18 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=11573
7 years, 2 months ago (2013-10-16 05:01:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/27459002/1
7 years, 2 months ago (2013-10-16 05:05:09 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 10:42:45 UTC) #6
Message was sent while issue was closed.
Change committed as 159753

Powered by Google App Engine
This is Rietveld 408576698