Issue 27459002: Move DEFINE_TYPE_CASTS from Node.h to Assertions.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27459002: Move DEFINE_TYPE_CASTS from Node.h to Assertions.h (Closed)

Created:
7 years, 2 months ago by gyuyoung-inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent

CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Move DEFINE_TYPE_CASTS from Node.h to Assertions.h As mentioned in FIXME, DEFINE_TYPE_CASTS needs to find proper place. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159753

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -25 lines)			Patch
	M	Source/core/dom/Node.h	View		1 chunk	+0 lines, -25 lines	0 comments	Download
	M	Source/wtf/Assertions.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/27459002/1

7 years, 2 months ago (2013-10-16 03:41:18 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=11573

7 years, 2 months ago (2013-10-16 05:01:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/27459002/1

7 years, 2 months ago (2013-10-16 05:05:09 UTC) #5

Message was sent while issue was closed.

Change committed as 159753

Expand Messages | Collapse Messages