Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/modules/compositorworker/Animator.h

Issue 2745823002: [animation-worklet] Implement registerAnimator in worklet scope (Closed)
Patch Set: feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef Animator_h
6 #define Animator_h
7
8 #include "bindings/core/v8/ScopedPersistent.h"
9 #include "platform/heap/Handle.h"
10 #include "v8/include/v8.h"
11
12 namespace blink {
13
14 class ScriptState;
15 class AnimatorDefinition;
16
17 class Animator final : public GarbageCollectedFinalized<Animator> {
18 public:
19 static Animator* create(ScriptState*,
20 AnimatorDefinition*,
21 v8::Local<v8::Object> instance);
22 ~Animator();
23 DECLARE_TRACE();
24
25 private:
26 Animator(ScriptState*, AnimatorDefinition*, v8::Local<v8::Object> instance);
27
28 RefPtr<ScriptState> m_scriptState;
haraken 2017/03/14 20:33:02 Is this used?
majidvp 2017/05/18 21:05:02 not currently. Removed!
29
30 // This object keeps the definition object, and animator instance alive.
31 // It needs to be destroyed to break a reference cycle between it and the
32 // AnimationWorkletGlobalScope.
haraken 2017/03/14 20:33:02 Mention that it is broken at AnimationWorkletGloba
majidvp 2017/05/18 21:05:02 Done.
33 Member<AnimatorDefinition> m_definition;
34 ScopedPersistent<v8::Object> m_instance;
35 };
36
37 } // namespace blink
38
39 #endif // Animator_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698