Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2897)

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc

Issue 27458002: Allow setting different hit test bounds overrides for mouse and touch (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
index 1ab0c850699a56a3ba9c3697172c6bb7e7879664..597c8e314abfb3a4c5e78601341798ebfdb2266d 100644
--- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
@@ -238,8 +238,6 @@ IN_PROC_BROWSER_TEST_F(ImmersiveModeControllerAshTest,
ash::internal::ShelfLayoutManager* shelf =
ash::Shell::GetPrimaryRootWindowController()->GetShelfLayoutManager();
- controller()->SetForceHideTabIndicatorsForTest(false);
-
// The shelf should start out as visible.
ASSERT_EQ(ash::SHELF_VISIBLE, shelf->visibility_state());
@@ -289,36 +287,4 @@ IN_PROC_BROWSER_TEST_F(ImmersiveModeControllerAshTest,
EXPECT_TRUE(controller()->ShouldHideTabIndicators());
}
-// Validate top container touch insets are being updated at the correct time in
-// immersive mode.
-IN_PROC_BROWSER_TEST_F(ImmersiveModeControllerAshTest,
- ImmersiveTopContainerInsets) {
- content::WebContents* contents = browser_view()->GetActiveWebContents();
- aura::Window* window = contents->GetView()->GetContentNativeView();
-
- // Turning immersive mode on sets positive top touch insets on the render view
- // window.
- chrome::ToggleFullscreenMode(browser());
- ASSERT_TRUE(browser_view()->IsFullscreen());
- ASSERT_TRUE(controller()->IsEnabled());
- EXPECT_TRUE(window->hit_test_bounds_override_outer_touch().top() > 0);
-
- // Trigger a reveal resets insets as now the touch target for the top
- // container is large enough.
- controller()->StartRevealForTest(true);
- EXPECT_TRUE(window->hit_test_bounds_override_outer_touch().top() == 0);
-
- // End reveal by moving the mouse off the top-of-window views. We
- // should see the top insets being positive again to allow a bigger touch
- // target.
- controller()->SetMouseHoveredForTest(false);
- EXPECT_TRUE(window->hit_test_bounds_override_outer_touch().top() > 0);
-
- // Disabling immersive mode resets the top touch insets to 0.
- chrome::ToggleFullscreenMode(browser());
- ASSERT_FALSE(browser_view()->IsFullscreen());
- ASSERT_FALSE(controller()->IsEnabled());
- EXPECT_TRUE(window->hit_test_bounds_override_outer_touch().top() == 0);
-}
-
#endif // defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698