Allow setting different hit test bounds overrides for mouse and touch

ash/wm/window_state.cc

Index: ash/wm/window_state.cc
diff --git a/ash/wm/window_state.cc b/ash/wm/window_state.cc
index 2afba08d68f104fde02c523099d592422e59e859..f79023c1de00b3b0fff4ec209adbb05c1f3debf1 100644
--- a/ash/wm/window_state.cc
+++ b/ash/wm/window_state.cc
@@ -28,6 +28,7 @@ bool WindowState::IsMaximizedOrFullscreenState(ui::WindowShowState show_state) {
 
 WindowState::WindowState(aura::Window* window)
     : window_(window),
+      fullscreen_type_(FULLSCREEN_TYPE_OTHER),
       tracked_by_workspace_(true),
       window_position_managed_(false),
       bounds_changed_by_user_(false),
@@ -60,6 +61,13 @@ bool WindowState::IsFullscreen() const {
   return GetShowState() == ui::SHOW_STATE_FULLSCREEN;
 }
 
+bool WindowState::IsImmersiveFullscreen() const {
+  if (!IsFullscreen())
+    return false;
+  return fullscreen_type_ == FULLSCREEN_TYPE_IMMERSIVE_MINIMAL_CHROME ||
+      fullscreen_type_ == FULLSCREEN_TYPE_IMMERSIVE_NO_CHROME;
+}
+
 bool WindowState::IsMaximizedOrFullscreen() const {
   return IsMaximizedOrFullscreenState(GetShowState());
 }
@@ -191,6 +199,17 @@ void WindowState::ClearRestoreBounds() {
   window_->ClearProperty(aura::client::kRestoreBoundsKey);
 }
 
+void WindowState::SetFullscreenType(FullscreenType type) {

[James Cook, 2013/10/17 16:56:24]

Do you need to be able to change the fullscreen type even when you are not in
fullscreen?  If not, it might be clearer to require IsFullscreen() to make these
changes, either by returning early or DCHECK(IsFullScreen()). This would also
make it more clear about when ShowType change notifications happen vs.
FullscreenType change notifications.

If it has to be this way I might document why the notification pattern for
OnWindowFullscreenTypeChanged() has to be the way it is, maybe in the header.

[pkotwicz, 2013/10/17 22:14:27]

I now ignore calls to SetFullscreenType() when not in fullscreen.
However, in order to accomodate the new behavior, I have to reset
|fullscreen_type_| in OnWindowPropertyChanged().
I think this way is slightly easier to understand.

+  if (fullscreen_type_ == type)
+    return;
+  FullscreenType old = fullscreen_type_;
+  fullscreen_type_ = type;
+  if (IsFullscreen()) {
+    FOR_EACH_OBSERVER(WindowStateObserver, observer_list_,
+                      OnWindowFullscreenTypeChanged(this, old));
+  }
+}
+
 void WindowState::SetPreAutoManageWindowBounds(
     const gfx::Rect& bounds) {
   pre_auto_manage_window_bounds_.reset(new gfx::Rect(bounds));