Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

Issue 2745793004: Remove PaintInvalidatorContext::newVisualRect (Closed)
Patch Set: - Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
index f4a3e11d8bc7e34bc4d5fab52ddd176299c3eeae..0e6a2bebc9c206f82ea9645f91250e3e3c73b5fd 100644
--- a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
@@ -105,7 +105,7 @@ PaintInvalidationReason BoxPaintInvalidator::computePaintInvalidationReason() {
LayoutSize oldBorderBoxSize = m_box.previousSize();
LayoutSize newBorderBoxSize = m_box.size();
bool borderBoxChanged = oldBorderBoxSize != newBorderBoxSize;
- if (!borderBoxChanged && m_context.oldVisualRect == m_context.newVisualRect)
+ if (!borderBoxChanged && m_context.oldVisualRect == m_box.visualRect())
return PaintInvalidationNone;
// If either border box changed or bounds changed, and old or new border box
@@ -116,7 +116,7 @@ PaintInvalidationReason BoxPaintInvalidator::computePaintInvalidationReason() {
// - visual overflows.
if (m_context.oldVisualRect !=
LayoutRect(m_context.oldLocation, oldBorderBoxSize) ||
- m_context.newVisualRect !=
+ m_box.visualRect() !=
LayoutRect(m_context.newLocation, newBorderBoxSize)) {
return borderBoxChanged ? PaintInvalidationBorderBoxChange
: PaintInvalidationBoundsChange;
@@ -254,7 +254,7 @@ PaintInvalidationReason BoxPaintInvalidator::invalidatePaintIfNeeded() {
if (m_box.isLayoutView() &&
!RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
invalidated = incrementallyInvalidatePaint(
- reason, m_context.oldVisualRect, m_context.newVisualRect);
+ reason, m_context.oldVisualRect, m_box.visualRect());
} else {
invalidated = incrementallyInvalidatePaint(
reason, LayoutRect(m_context.oldLocation, m_box.previousSize()),
@@ -292,7 +292,7 @@ bool BoxPaintInvalidator::
needsToSavePreviousContentBoxSizeOrLayoutOverflowRect() {
// Don't save old box geometries if the paint rect is empty because we'll
// fully invalidate once the paint rect becomes non-empty.
- if (m_context.newVisualRect.isEmpty())
+ if (m_box.visualRect().isEmpty())
return false;
if (m_box.paintedOutputOfObjectHasNoEffectRegardlessOfSize())

Powered by Google App Engine
This is Rietveld 408576698