Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7959)

Unified Diff: chrome/browser/resources/options/controlled_setting.js

Issue 2745733004: Options: fix "Manage extension" link in controlled-by-extension bubbles (Closed)
Patch Set: window.open() instead Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/controlled_setting.js
diff --git a/chrome/browser/resources/options/controlled_setting.js b/chrome/browser/resources/options/controlled_setting.js
index fc5b960ab334c6c82e3bbaa261c310fc6bcb3824..7b383215ac49147f1fef4c4c76a3829bf6f12717 100644
--- a/chrome/browser/resources/options/controlled_setting.js
+++ b/chrome/browser/resources/options/controlled_setting.js
@@ -174,9 +174,13 @@ cr.define('options', function() {
'.controlled-setting-bubble-extension-manage-link');
var extensionId = this.extensionId;
manageLink.onclick = function() {
- uber.invokeMethodOnWindow(
- window.top, 'showPage',
- {pageId: 'extensions', path: '?id=' + extensionId});
+ if (window != window.top) {
+ uber.invokeMethodOnWindow(
+ window.top, 'showPage',
+ {pageId: 'extensions', path: '?id=' + extensionId});
+ } else {
+ window.open('chrome://extensions/?id=' + extensionId);
+ }
};
var disableButton = extensionContainer.querySelector(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698