Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: ios/web_view/shell/BUILD.gn

Issue 2745653010: Create ChromeWebView Framework. (Closed)
Patch Set: Respond to comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web_view/public/BUILD.gn ('k') | ios/web_view/shell/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/shell/BUILD.gn
diff --git a/ios/web_view/shell/BUILD.gn b/ios/web_view/shell/BUILD.gn
index 389cc5907e5d776a21828c43f33db63cef3805ba..14032cdfa5b560eecaa20d1a5fe801a05771abde 100644
--- a/ios/web_view/shell/BUILD.gn
+++ b/ios/web_view/shell/BUILD.gn
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("//tools/grit/repack.gni")
import("//build/config/ios/rules.gni")
ios_app_bundle("ios_web_view_shell") {
@@ -10,11 +9,10 @@ ios_app_bundle("ios_web_view_shell") {
deps = [
":shell",
+ "//ios/web_view",
+ "//ios/web_view:web_view+link",
]
- bundle_deps = [
- ":resources",
- ":packed_resources",
- ]
+ bundle_deps = [ "//ios/web_view:web_view+bundle" ]
configs += [ "//build/config/compiler:enable_arc" ]
}
@@ -33,7 +31,7 @@ source_set("shell") {
]
deps = [
- "//base",
+ ":resources",
"//ios/web_view",
]
@@ -56,7 +54,7 @@ source_set("shell") {
}
bundle_data("resources") {
- visibility = [ ":ios_web_view_shell" ]
+ visibility = [ ":shell" ]
sources = [
"Default-568h@2x.png",
"textfield_background@2x.png",
@@ -68,27 +66,3 @@ bundle_data("resources") {
"{{bundle_resources_dir}}/{{source_file_part}}",
]
}
-
-repack("repack_resources") {
- visibility = [ ":packed_resources" ]
- deps = [
- "//components/resources:components_resources",
- ]
- sources = [
- "$root_gen_dir/components/components_resources.pak",
- ]
- output = "$target_gen_dir/web_view_resources.pak"
-}
-
-bundle_data("packed_resources") {
- visibility = [ ":ios_web_view_shell" ]
- public_deps = [
- ":repack_resources",
- ]
- sources = [
- "$target_gen_dir/web_view_resources.pak",
- ]
- outputs = [
- "{{bundle_resources_dir}}/{{source_file_part}}",
- ]
-}
« no previous file with comments | « ios/web_view/public/BUILD.gn ('k') | ios/web_view/shell/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698