Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ios/web_view/internal/cwv.mm

Issue 2745653010: Create ChromeWebView Framework. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/cwv.mm
diff --git a/ios/web_view/internal/cwv.mm b/ios/web_view/internal/cwv.mm
index e24120c1a1985f14fbb336f437ad0236e121a6bb..697bdc709662d8cd5720c460d518518a1a98643d 100644
--- a/ios/web_view/internal/cwv.mm
+++ b/ios/web_view/internal/cwv.mm
@@ -8,6 +8,7 @@
#include "base/location.h"
#import "base/mac/bind_objc_block.h"
+#import "base/mac/bundle_locations.h"
Eugene But (OOO till 7-30) 2017/03/11 01:15:01 s/import/include
michaeldo 2017/03/13 17:27:01 Please confirm, bundle_locations imports Foundatio
#include "base/memory/ptr_util.h"
#include "base/single_thread_task_runner.h"
#include "ios/web/public/app/web_main.h"
@@ -41,6 +42,7 @@ CWV* g_criwv = nil;
@synthesize delegate = _delegate;
+ (void)configureWithDelegate:(id<CWVDelegate>)delegate {
+ base::mac::SetOverrideFrameworkBundle([NSBundle bundleForClass:[self class]]);
Eugene But (OOO till 7-30) 2017/03/11 01:15:01 We should get rid of CWV class. Is there a better
michaeldo 2017/03/13 17:27:01 I agree this class will go away soon, but I think
Eugene But (OOO till 7-30) 2017/03/13 20:37:12 Sure.
g_criwv = [[CWV alloc] initWithDelegate:delegate];
}

Powered by Google App Engine
This is Rietveld 408576698