Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: ios/web_view/BUILD.gn

Issue 2745653010: Create ChromeWebView Framework. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web_view/Info.plist » ('j') | ios/web_view/Info.plist » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/BUILD.gn
diff --git a/ios/web_view/BUILD.gn b/ios/web_view/BUILD.gn
index 1755748783f025fd9447a2945e68dbeaa39c27f5..4a75457f091ca00e43ef57394e7aee9b36deafef 100644
--- a/ios/web_view/BUILD.gn
+++ b/ios/web_view/BUILD.gn
@@ -2,13 +2,95 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-# Public target that should be used to depend on web_view. Only give access
-# to the web_view public headers while still linking with the implementation.
-group("web_view") {
- public_deps = [
+import("//build/config/ios/ios_sdk.gni")
+import("//build/config/ios/rules.gni")
+import("//tools/grit/repack.gni")
+
+config("config") {
+ include_dirs = [
+ "//ios/web_view/internal",
"//ios/web_view/public",
]
+}
+
+ios_framework_bundle("web_view") {
+ output_name = "ChromeWebView"
+ info_plist = "Info.plist"
+
+ sources = [
+ "public/cwv.h",
+ ]
+
+ public_headers = [
+ "public/criwv_translate_manager.h",
+ "public/cwv.h",
+ "public/cwv_delegate.h",
+ "public/cwv_html_element.h",
+ "public/cwv_navigation_delegate.h",
+ "public/cwv_translate_delegate.h",
+ "public/cwv_ui_delegate.h",
+ "public/cwv_web_view.h",
+ "public/cwv_web_view_configuration.h",
+ "public/cwv_website_data_store.h",
+ ]
+
deps = [
+ ":packed_resources",
+ "//base",
+ "//components/infobars/core",
+ "//components/keyed_service/core",
+ "//components/keyed_service/ios",
+ "//components/pref_registry",
+ "//components/prefs",
+ "//components/translate/core/browser",
+ "//components/translate/core/common",
+ "//components/translate/ios/browser",
+ "//ios/net",
+ "//ios/web",
+ "//ios/web:user_agent",
+ "//ios/web/public/app",
"//ios/web_view/internal",
+ "//net",
+ "//net:extras",
+ "//ui/base",
+ "//url",
+ ]
+
+ public_deps = [
+ "//ios/web_view/public",
+ ]
+
+ libs = [ "UIKit.framework" ]
+
+ public_configs = [ ":config" ]
+
+ configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
sdefresne 2017/03/13 10:32:24 Why do you need to use configs to change the visib
michaeldo 2017/03/13 17:27:00 It does work and I can remove this. I copied this
+ configs += [
+ "//build/config/compiler:enable_arc",
+ "//build/config/gcc:symbol_visibility_default",
+ ]
+}
+
+repack("repack_resources") {
+ visibility = [ ":packed_resources" ]
+ deps = [
+ "//components/resources:components_resources",
sdefresne 2017/03/13 10:32:23 Don't you also want to include //ios/web:resources
michaeldo 2017/03/13 17:27:00 yes, you are right, I added it. Thank you for like
+ ]
+ sources = [
+ "$root_gen_dir/components/components_resources.pak",
+ ]
+ output = "$target_gen_dir/web_view_resources.pak"
+}
+
+bundle_data("packed_resources") {
+ visibility = [ "//ios/web_view:*" ]
+ public_deps = [
+ ":repack_resources",
+ ]
+ sources = [
+ "$target_gen_dir/web_view_resources.pak",
+ ]
+ outputs = [
+ "{{bundle_resources_dir}}/{{source_file_part}}",
]
}
« no previous file with comments | « no previous file | ios/web_view/Info.plist » ('j') | ios/web_view/Info.plist » ('J')

Powered by Google App Engine
This is Rietveld 408576698