Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: chrome/utility/media_router/dial_device_description_parser_impl.cc

Issue 2745653008: [Media Router] Parse device description xml in utility process (Closed)
Patch Set: fix android build error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/utility/media_router/dial_device_description_parser_impl.cc
diff --git a/chrome/utility/media_router/dial_device_description_parser_impl.cc b/chrome/utility/media_router/dial_device_description_parser_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b02b01020e089ef42e0c9c9997cbf9d85c338e83
--- /dev/null
+++ b/chrome/utility/media_router/dial_device_description_parser_impl.cc
@@ -0,0 +1,114 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/utility/media_router/dial_device_description_parser_impl.h"
+
+#include <libxml/parser.h>
+#include <libxml/tree.h>
+#include <libxml/xpath.h>
+#include <utility>
+
+#include "base/memory/ptr_util.h"
+#include "base/strings/stringprintf.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "third_party/libxml/chromium/libxml_utils.h"
+
+namespace {
+
+enum ErrorType {
+ NONE,
+ MISSING_UNIQUE_ID,
+ MISSING_FRIENDLY_NAME,
+};
+
+ErrorType Validate(const chrome::mojom::DialDeviceDescription& description) {
+ if (description.unique_id.empty()) {
+ return ErrorType::MISSING_UNIQUE_ID;
+ }
+ if (description.friendly_name.empty()) {
+ return ErrorType::MISSING_FRIENDLY_NAME;
+ }
+ return ErrorType::NONE;
+}
+
+// If friendly name does not exist, fall back to use model name + last 4
+// digits of UUID as friendly name.
+std::string ComputeFriendlyName(const std::string& unique_id,
+ const std::string& model_name) {
+ if (model_name.empty() || unique_id.length() < 4)
+ return std::string();
+
+ std::string trimmed_unique_id = unique_id.substr(unique_id.length() - 4);
+ return base::StringPrintf("%s [%s]", model_name.c_str(),
+ trimmed_unique_id.c_str());
+}
+
+} // namespace
+
+namespace media_router {
+
+DialDeviceDescriptionParserImpl::DialDeviceDescriptionParserImpl() = default;
+DialDeviceDescriptionParserImpl::~DialDeviceDescriptionParserImpl() {
+ DCHECK(thread_checker_.CalledOnValidThread());
+}
+
+// static
+void DialDeviceDescriptionParserImpl::Create(
+ chrome::mojom::DialDeviceDescriptionParserRequest request) {
+ mojo::MakeStrongBinding(base::MakeUnique<DialDeviceDescriptionParserImpl>(),
+ std::move(request));
+}
+
+void DialDeviceDescriptionParserImpl::ParseDialDeviceDescription(
+ const std::string& device_description_xml_data,
+ const ParseDialDeviceDescriptionCallback& callback) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK(!callback.is_null());
+
+ chrome::mojom::DialDeviceDescriptionPtr device_description =
+ Parse(device_description_xml_data);
+ callback.Run(std::move(device_description));
+}
+
+chrome::mojom::DialDeviceDescriptionPtr DialDeviceDescriptionParserImpl::Parse(
+ const std::string& xml) {
+ XmlReader xml_reader;
+ if (!xml_reader.Load(xml))
+ return nullptr;
+
+ chrome::mojom::DialDeviceDescriptionPtr out =
+ chrome::mojom::DialDeviceDescription::New();
+
+ while (xml_reader.Read()) {
+ xml_reader.SkipToElement();
+ std::string node_name(xml_reader.NodeName());
+
+ if (node_name == "UDN") {
+ if (!xml_reader.ReadElementContent(&out->unique_id))
+ return nullptr;
+ } else if (node_name == "friendlyName") {
+ if (!xml_reader.ReadElementContent(&out->friendly_name))
+ return nullptr;
+ } else if (node_name == "modelName") {
+ if (!xml_reader.ReadElementContent(&out->model_name))
+ return nullptr;
+ } else if (node_name == "deviceType") {
+ if (!xml_reader.ReadElementContent(&out->device_type))
+ return nullptr;
+ }
+ }
+
+ if (out->friendly_name.empty())
+ out->friendly_name = ComputeFriendlyName(out->unique_id, out->model_name);
+
+ ErrorType error = Validate(*out);
+ if (error != ErrorType::NONE) {
+ DLOG(WARNING) << "Device description failed to validate: " << error;
+ return nullptr;
+ }
+
+ return out;
+}
+
+} // namespace media_router

Powered by Google App Engine
This is Rietveld 408576698