[Media Router] Parse device description xml in utility process

chrome/browser/media/router/discovery/safe_dial_device_description_parser.cc

Index: chrome/browser/media/router/discovery/safe_dial_device_description_parser.cc
diff --git a/chrome/browser/media/router/discovery/safe_dial_device_description_parser.cc b/chrome/browser/media/router/discovery/safe_dial_device_description_parser.cc
new file mode 100644
index 0000000000000000000000000000000000000000..89c0004653c9906971ba1608147469f1241b0007
--- /dev/null
+++ b/chrome/browser/media/router/discovery/safe_dial_device_description_parser.cc
@@ -0,0 +1,75 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/router/discovery/safe_dial_device_description_parser.h"
+
+#include <utility>

[imcheng, 2017/03/22 00:31:46]

Is this used?

[zhaobin, 2017/03/22 01:55:31]

Done.

+
+#include "chrome/common/extensions/chrome_utility_extensions_messages.h"

[imcheng, 2017/03/22 00:31:46]

Not used?

[zhaobin, 2017/03/22 01:55:31]

Done.

+#include "chrome/grit/generated_resources.h"
+#include "content/public/browser/browser_thread.h"
+#include "ui/base/l10n/l10n_util.h"
+
+using content::BrowserThread;

[imcheng, 2017/03/22 00:31:46]

This doesn't seem to be used - remove?

[zhaobin, 2017/03/22 01:55:31]

Done.

+using content::UtilityProcessHost;
+
+namespace media_router {
+
+SafeDialDeviceDescriptionParser::SafeDialDeviceDescriptionParser() {}
+
+SafeDialDeviceDescriptionParser::~SafeDialDeviceDescriptionParser() {}
+
+void SafeDialDeviceDescriptionParser::Start(
+    const std::string& xml_text,
+    const DeviceDescriptionCallback& callback) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(!utility_process_mojo_client_);
+  DCHECK(callback);
+
+  device_description_callback_ = callback;
+
+  utility_process_mojo_client_ =
+      base::MakeUnique<content::UtilityProcessMojoClient<
+          chrome::mojom::DialDeviceDescriptionParser>>(
+          l10n_util::GetStringUTF16(
+              IDS_UTILITY_PROCESS_DIAL_DEVICE_DESCRIPTION_PARSER_NAME));
+
+  utility_process_mojo_client_->set_error_callback(base::Bind(
+      &SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionFailed, this));
+
+  // This starts utility process in the background.
+  utility_process_mojo_client_->Start();
+
+  // This call is queued up until the Mojo message pipe has been established to
+  // the service running in the utility process.
+  utility_process_mojo_client_->service()->ParseDialDeviceDescription(
+      xml_text,
+      base::Bind(
+          &SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionComplete,
+          this));

[imcheng, 2017/03/22 00:31:46]

Unless you have ref counting for other purposes, can this be
base::Unretained(this)? It looks like the callback won't get invoked after this
class is destroyed.

[zhaobin, 2017/03/22 01:55:31]

Done.

+}
+
+void SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionComplete(
+    bool result,
+    const base::Optional<media_router::DialDeviceDescription>&
+        device_description) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+
+  utility_process_mojo_client_.reset();  // Terminate the utility process.
+
+  DCHECK(!device_description_callback_.is_null());
+  device_description_callback_.Run(result, device_description);
+}
+
+void SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionFailed() {
+  DCHECK(thread_checker_.CalledOnValidThread());
+
+  utility_process_mojo_client_.reset();  // Terminate the utility process.
+
+  DCHECK(!device_description_callback_.is_null());
+  device_description_callback_.Run(
+      false, base::Optional<media_router::DialDeviceDescription>());
+}
+
+}  // namespace media_router