[Media Router] Parse device description xml in utility process

chrome/common/extensions/dial_device_description_parser.mojom

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// DIAL device description parsing interface provided by the utility process and
+// exposed by mojo policy control to the chrome browser process.
+
+module extensions.mojom;

[mark a. foltz, 2017/03/17 19:05:47]

Is this going to be used only from extensions?  It seems like it could go in
media_router.mojom.

I'm not make sure it makes sense to add a chrome.dial API for this service,
since the DOM XML parsing is sufficient, and the incremental security benefit of
moving the parsing out of the extension process would be short lived.

[zhaobin, 2017/03/18 00:17:39]

Moved mojo related files to common/media_router/. Cannot add it to
browser/media/router/mojo/media_router.mojom file since chrome/utility does not
have access to chrome/browser headers. Other .mojom files in chrome/common use
"module chrome.mojom". Keep that instead of changing it to "module
media_router.mojom"...

+
+struct DialDeviceDescription {

[mark a. foltz, 2017/03/17 19:05:47]

Can you document the meanings of these fields, maybe copying from the dial.idl
documentation or the extension documentation?

[zhaobin, 2017/03/18 00:17:38]

Done.

+  string unique_id;
+  string friendly_name;
+  string model_name;
+  string device_type;
+};
+
+interface DialDeviceDescriptionParser {
+  // Parses |device_description_xml_data| to get device description data. If
+  // parsing succeeds, invokes callback with |parse_result| equals to true;
+  // otherwise invokes callback with |parse_result| equals to false.
+  // |device_description|: device description object. Empty if parsing fails.
+  // |logging_xml|: xml file for logging without unique ID and serial number.
+  ParseDialDeviceDescription(string device_description_xml_data)
+      => (bool parse_result,
+          DialDeviceDescription device_description,
+          string logging_xml);
+};